From owner-freebsd-threads@FreeBSD.ORG  Wed May  7 13:08:52 2003
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E4A1F37B401; Wed,  7 May 2003 13:08:50 -0700 (PDT)
Received: from rwcrmhc53.attbi.com (rwcrmhc53.attbi.com [204.127.198.39])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 247C743FAF; Wed,  7 May 2003 13:08:48 -0700 (PDT)
	(envelope-from julian@elischer.org)
Received: from interjet.elischer.org
	(12-232-168-4.client.attbi.com[12.232.168.4])
	by attbi.com (rwcrmhc53) with ESMTP
	id <2003050720084705300fc0q9e>; Wed, 7 May 2003 20:08:47 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id NAA47642;
	Wed, 7 May 2003 13:08:47 -0700 (PDT)
Date: Wed, 7 May 2003 13:08:46 -0700 (PDT)
From: Julian Elischer <julian@elischer.org>
To: Daniel Eischen <eischen@pcnet1.pcnet.com>
In-Reply-To: <Pine.GSO.4.10.10305060910120.11430-100000@pcnet1.pcnet.com>
Message-ID: <Pine.BSF.4.21.0305071307260.47162-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: threads@freebsd.org
cc: David Xu <davidxu@freebsd.org>
Subject: Re: kern_threads.c..  upcall question..
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 May 2003 20:08:53 -0000



On Tue, 6 May 2003, Daniel Eischen wrote:

> On Tue, 6 May 2003, Julian Elischer wrote:
> > 
> > On Tue, 6 May 2003, David Xu wrote:
> > 
> > > 
> > > > I think this could be optimised even more.
> > > > (why copy the FP regs if they are not valid) (etc).
> > > > but it is an improvement..
> > > > 
> > > 
> > > Why need we an intermediate mcontext_t, why not
> > > direct copy the context in trap frame to userland space?
> > > This should be fastest. :-)
> > 
> > this is what I was thinking..
> > get_mcontext_user(td, addr)
> > [...]
> 
> Don't break validation and setting of FP validity and type.
> get_mcontext() knows how to mark the validity of the FPU
> set and it's type (387 or SSE).  The UTS relies on this
> information.  Be very careful.

Can you test david's simple patch that just removes the copy-in?
We can wate til later to do the optimisations..

> 
> -- 
> Dan Eischen
> 
>