From owner-freebsd-hackers@FreeBSD.ORG  Tue Mar  4 15:15:33 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8AC71106566C
	for <hackers@freebsd.org>; Tue,  4 Mar 2008 15:15:33 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 4539B8FC21
	for <hackers@freebsd.org>; Tue,  4 Mar 2008 15:15:33 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 4E77746B2A;
	Tue,  4 Mar 2008 10:15:32 -0500 (EST)
Date: Tue, 4 Mar 2008 15:15:32 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20080303.224256.635730757.imp@bsdimp.com>
Message-ID: <20080304151326.J41184@fledge.watson.org>
References: <20080303.224256.635730757.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: hackers@freebsd.org
Subject: Re: Comments on pmake diffs for building on Linux
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Mar 2008 15:15:33 -0000


On Mon, 3 Mar 2008, M. Warner Losh wrote:

> --- pmake.orig/config.h	2005-02-01 03:50:35.000000000 -0700
> +++ pmake/config.h	2008-03-03 22:24:16.745493000 -0700
> @@ -108,4 +108,27 @@
> # endif
> #endif
>
> +#ifndef TAILQ_HEAD_INITIALIZER
> +#define TAILQ_HEAD_INITIALIZER(head) { NULL, &(head).tqh_first }
> +#endif

In most ports of FreeBSD parts to Linux that I've seen, the preferred solution 
has to been to bring the entire FreeBSD queue.h with you rather than relying 
on the native Linux queue.h.  This is what we do for OpenBSM, for example; 
this also helps out when you get to Mac OS X, Solaris, etc, where all the 
queue.h's continue to vary in subtle ways.  This depends a fair amount on a 
lack of header pollution in the OS's own include files, of course...

Robert N M Watson
Computer Laboratory
University of Cambridge