Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 02 Sep 2012 18:07:24 -0500
From:      Alan Cox <alc@rice.edu>
To:        Juli Mallett <jmallett@freebsd.org>
Cc:        mips@freebsd.org, Alan Cox <alc@rice.edu>
Subject:   gxemul_disk.c
Message-ID:  <5043E6AC.8040101@rice.edu>

next in thread | raw e-mail | index | archive | help
There appears to be a simple typo in gxemul_disk.c that prevents changes 
from being written back to the emulated disk:

Index: dev/gxemul/disk/gxemul_disk.c
===================================================================
--- dev/gxemul/disk/gxemul_disk.c       (revision 240002)
+++ dev/gxemul/disk/gxemul_disk.c       (working copy)
@@ -286,7 +286,7 @@ gxemul_disk_write(unsigned diskid, const void *buf
         dst = GXEMUL_DISK_DEV_FUNCTION(GXEMUL_DISK_DEV_BLOCK);
         memcpy((void *)(uintptr_t)dst, buf, GXEMUL_DISK_DEV_BLOCKSIZE);

-       GXEMUL_DISK_DEV_WRITE(GXEMUL_DISK_DEV_START, 
GXEMUL_DISK_DEV_START_READ);
+       GXEMUL_DISK_DEV_WRITE(GXEMUL_DISK_DEV_START, 
GXEMUL_DISK_DEV_START_WRITE);
         switch (GXEMUL_DISK_DEV_READ(GXEMUL_DISK_DEV_STATUS)) {
         case GXEMUL_DISK_DEV_STATUS_FAILURE:
                 return (EIO);

Or am I missing something?

Regards,
Alan




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5043E6AC.8040101>