From owner-svn-src-head@freebsd.org Thu Nov 10 21:25:21 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 885D5C3ADD4; Thu, 10 Nov 2016 21:25:21 +0000 (UTC) (envelope-from rionda@gmail.com) Received: from mail-qk0-x22f.google.com (mail-qk0-x22f.google.com [IPv6:2607:f8b0:400d:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 41C8A24B; Thu, 10 Nov 2016 21:25:21 +0000 (UTC) (envelope-from rionda@gmail.com) Received: by mail-qk0-x22f.google.com with SMTP id n204so302956670qke.2; Thu, 10 Nov 2016 13:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=O+JzQDc/2o65igbCvQsUdwEz5AGfyWOtRliDE3nKB9U=; b=MmN/dAGivUZ83Y8ed44Vh31nTFSz0IPIqGKtftOlE3/OyNvdNBmhs8ZJ5HvgUh7dt1 NBVHSDE81rmCRI4mYYNgfKNX1nMTXcGgIN+I2ompo4aOESNgnykI93b80UMrBnSy5laQ ubkizEEL+uS+G0C/A/mDwDtRG5o6c9Baxn+UfaPpBNO0zUoRDzyTnr9vJB2cPoAaIrK2 DQsSGSXDwTBuvS6sNarfwntm3DaWmlPxvTM+uFpBTI3eTK8N9wled3z9cn2R++VIdiKu P466dnYR2qXu48mm7BlpiGUbKdqopOmzw9rbM5z0w0W/W4GvpZ83fH8NjXtq9jc1QFP/ P0wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=O+JzQDc/2o65igbCvQsUdwEz5AGfyWOtRliDE3nKB9U=; b=Gg7kkZQDtPRUaobu2Ikhw7D4M5iKon7K334i3g3vKQidBHb3PHjorJZI0sPzd8Z6BO Gy2dbvVhfXOKXDcvH+t1BhGoVYcgkbWwZFFyy+EoUQGZt5OmiZqA5ZmxOzWmH1ZAcVhB Hc8D+Vx0uoP408C/RqFUxdSfCPi2z9DCVBng+IQ4fykwzU2f+lBNIN0tQK27P7ZC9NmR hegesm1gmYnCWXqgXJiEsa3HGyUeX/dk9Gz1YRWpnTZTqRIDyeU+nkxNc1GkboYi5evB 8edaWG1P8mC/V3qNbPpc7YsCUUDlp7akBc7DEqyc6vPCp3Lnb5jDRe6A7YbUQ4vxczwF uRpA== X-Gm-Message-State: ABUngvcST37nrKcYowGNnAT3b2XmECKATN5waA853I+AchyX+pVWvgE++fxMS+Z2yi7UIw== X-Received: by 10.55.140.194 with SMTP id o185mr7720970qkd.243.1478813120190; Thu, 10 Nov 2016 13:25:20 -0800 (PST) Received: from [172.31.26.254] (gzac12-mdf2-1.aoa.twosigma.com. [208.77.215.155]) by smtp.gmail.com with ESMTPSA id v127sm3579880qkb.29.2016.11.10.13.25.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Nov 2016 13:25:19 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\)) Subject: Re: svn commit: r308175 - head/libexec/ftpd From: Matteo Riondato In-Reply-To: <201611011818.uA1II9oe069262@repo.freebsd.org> Date: Thu, 10 Nov 2016 16:25:18 -0500 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201611011818.uA1II9oe069262@repo.freebsd.org> To: Kurt Lidl X-Mailer: Apple Mail (2.3251) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2016 21:25:21 -0000 > On Nov 1, 2016, at 2:18 PM, Kurt Lidl wrote: >=20 > Author: lidl > Date: Tue Nov 1 18:18:09 2016 > New Revision: 308175 > URL: https://svnweb.freebsd.org/changeset/base/308175 >=20 > Log: > Revisit blacklistd support in ftpd This commit is breaking buildworld for me with WITHOUT_BLACKLIST=3Dy in = src.conf : --- ftpd.o --- /usr/src/libexec/ftpd/ftpd.c:656:2: warning: implicit declaration of = function 'BLACKLIST_INIT' is invalid in C99 = [-Wimplicit-function-declaration] BLACKLIST_INIT(); ^ /usr/src/libexec/ftpd/ftpd.c:1432:4: warning: implicit declaration of = function 'BLACKLIST_NOTIFY' is invalid in C99 = [-Wimplicit-function-declaration] BLACKLIST_NOTIFY(BLACKLIST_AUTH_FAIL, = STDIN_FILENO, "Login incorrect"); ^ /usr/src/libexec/ftpd/ftpd.c:1432:21: error: use of undeclared = identifier 'BLACKLIST_AUTH_FAIL'; did you mean 'BLACKLIST_NOTIFY'? BLACKLIST_NOTIFY(BLACKLIST_AUTH_FAIL, = STDIN_FILENO, "Login incorrect"); ^~~~~~~~~~~~~~~~~~~ BLACKLIST_NOTIFY /usr/src/libexec/ftpd/ftpd.c:1432:4: note: 'BLACKLIST_NOTIFY' declared = here BLACKLIST_NOTIFY(BLACKLIST_AUTH_FAIL, = STDIN_FILENO, "Login incorrect"); ^ /usr/src/libexec/ftpd/ftpd.c:1450:21: error: use of undeclared = identifier 'BLACKLIST_AUTH_OK'; did you mean 'BLACKLIST_NOTIFY'? BLACKLIST_NOTIFY(BLACKLIST_AUTH_OK, = STDIN_FILENO, "Login successful"); ^~~~~~~~~~~~~~~~~ BLACKLIST_NOTIFY /usr/src/libexec/ftpd/ftpd.c:1432:4: note: 'BLACKLIST_NOTIFY' declared = here BLACKLIST_NOTIFY(BLACKLIST_AUTH_FAIL, = STDIN_FILENO, "Login incorrect"); ^ 2 warnings and 2 errors generated. *** [ftpd.o] Error code 1 Matteo