From owner-cvs-all@FreeBSD.ORG  Fri Apr  8 03:47:08 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 39A81106566C;
	Fri,  8 Apr 2011 03:47:08 +0000 (UTC)
	(envelope-from bf1783@googlemail.com)
Received: from mail-px0-f172.google.com (mail-px0-f172.google.com
	[209.85.212.172])
	by mx1.freebsd.org (Postfix) with ESMTP id E722B8FC13;
	Fri,  8 Apr 2011 03:47:07 +0000 (UTC)
Received: by pxi6 with SMTP id 6so2950492pxi.17
	for <multiple recipients>; Thu, 07 Apr 2011 20:47:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=googlemail.com; s=gamma;
	h=domainkey-signature:mime-version:reply-to:in-reply-to:references
	:date:message-id:subject:from:to:cc:content-type;
	bh=LFZhKi9a8wqKSDAKo+L8hoCRyKAJLYXE3PFpmvvt0/A=;
	b=cDlW7bXZwsl3hRFEGZs2V84VHl3C2g9dpwQ4WGGdLQf/jHRrnC3FYCBNF9ceD1WBGd
	KsGUjDlKHKXisiGty/+gjfL8rQ0uax3obXLJBcI+6vB2aRc92CWh2REwaxpJoG4WmJw3
	V1cBqCxNZpCZ+ffkWA9bTRYAimHy8FAdz7c5w=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma;
	h=mime-version:reply-to:in-reply-to:references:date:message-id
	:subject:from:to:cc:content-type;
	b=jNcBnZHNXqtFTx2Xlvna4bv020knk0yOw3Td+1k5IBtyQ8isoqUvrPKYkiR/xzzVVv
	zGNulpxJvq4en3WHxxifhB6QT0Q3EoFAdPPH4TSFvSk8dKSJwwyDp/nPagMqTu94c6vk
	oXYgzTDqvpuYA4E2FJgx/67PC35pv+f+1LgEY=
MIME-Version: 1.0
Received: by 10.142.161.10 with SMTP id j10mr1313165wfe.250.1302234427351;
	Thu, 07 Apr 2011 20:47:07 -0700 (PDT)
Received: by 10.68.47.6 with HTTP; Thu, 7 Apr 2011 20:47:07 -0700 (PDT)
In-Reply-To: <20110408023021.GA47293@FreeBSD.org>
References: <201104072239.p37Md9oh031253@repoman.freebsd.org>
	<BANLkTikmUZsHNjw2Jpe8Y7v5CD6WkZGtoQ@mail.gmail.com>
	<20110408022459.GA40411@FreeBSD.org>
	<20110408023021.GA47293@FreeBSD.org>
Date: Fri, 8 Apr 2011 03:47:07 +0000
Message-ID: <BANLkTik4HrVvVNU_nBtH8Oyt=81uKjn6og@mail.gmail.com>
From: "b. f." <bf1783@googlemail.com>
To: Alexey Dokuchaev <danfe@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Rene Ladan <rene@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: cvs commit: ports/www/chromium Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: bf1783@gmail.com
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Apr 2011 03:47:08 -0000

On 4/8/11, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Fri, Apr 08, 2011 at 02:24:59AM +0000, Alexey Dokuchaev wrote:
>> I've been thinking about this as well.  However, instead of bringing back
>> this OPTION, I'd suggest adding "|| defined(PACKAGE_BUILDING)" to that
>> .if to ensure that packages are can be safely run on pre-SSE2 CPUs.
>
> Diff attached, seems to DTRT.

Someone may want to build SSE2-enabled packages for i386 in a
tinderbox or on a package-building machine, and the option allows them
to do this, but this change does not.  Also, with this change, you're
telling the configure script to disable SSE2 when PACKAGE_BUILDING is
defined even on amd64, where SSE2 is always available.  So I don't
think it DTRT.

b.