Date: Fri, 8 Apr 2011 03:47:07 +0000 From: "b. f." <bf1783@googlemail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Rene Ladan <rene@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/www/chromium Makefile Message-ID: <BANLkTik4HrVvVNU_nBtH8Oyt=81uKjn6og@mail.gmail.com> In-Reply-To: <20110408023021.GA47293@FreeBSD.org> References: <201104072239.p37Md9oh031253@repoman.freebsd.org> <BANLkTikmUZsHNjw2Jpe8Y7v5CD6WkZGtoQ@mail.gmail.com> <20110408022459.GA40411@FreeBSD.org> <20110408023021.GA47293@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/8/11, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Fri, Apr 08, 2011 at 02:24:59AM +0000, Alexey Dokuchaev wrote: >> I've been thinking about this as well. However, instead of bringing back >> this OPTION, I'd suggest adding "|| defined(PACKAGE_BUILDING)" to that >> .if to ensure that packages are can be safely run on pre-SSE2 CPUs. > > Diff attached, seems to DTRT. Someone may want to build SSE2-enabled packages for i386 in a tinderbox or on a package-building machine, and the option allows them to do this, but this change does not. Also, with this change, you're telling the configure script to disable SSE2 when PACKAGE_BUILDING is defined even on amd64, where SSE2 is always available. So I don't think it DTRT. b.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTik4HrVvVNU_nBtH8Oyt=81uKjn6og>