Date: Thu, 28 Jul 2011 07:40:21 -0400 From: "b. f." <bf1783@googlemail.com> To: Mario Sergio Fujikawa Ferreira <lioux@freebsd.org> Cc: Doug Barton <dougb@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org, riggs@rrr.de, "Philip M. Gollucci" <pgollucci@p6m7g8.com>, cvs-ports@freebsd.org Subject: Re: cvs commit: ports/multimedia/mencoder Makefile Message-ID: <CAGFTUwOU_PXVS4agENXow%2Bm1nzYEL_Qa09ZELwy7xqE=j9HO3w@mail.gmail.com> In-Reply-To: <CAGFTUwM=-hMoA=kEt3vtzG1n7WG2xeD5g=6OoqVXH6QHSGhs-A@mail.gmail.com> References: <201107200252.p6K2qZRb053515@repoman.freebsd.org> <CAGFTUwMZ5iAp=VvNZezX4fiGy2d5Ep6jaSWWUZp92KTobxkjsQ@mail.gmail.com> <4E2B2B82.1020506@FreeBSD.org> <4E2D7EEC.8030600@p6m7g8.com> <20110726025646.74097.qmail@exxodus.fedaykin.here> <20110726032009.23147.qmail@exxodus.fedaykin.here> <CAGFTUwM=-hMoA=kEt3vtzG1n7WG2xeD5g=6OoqVXH6QHSGhs-A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--bcaec5215d9b45643504a91fa1f9 Content-Type: text/plain; charset=ISO-8859-1 On 7/26/11, b. f. <bf1783@googlemail.com> wrote: > On 7/25/11, Mario Sergio Fujikawa Ferreira <lioux@freebsd.org> wrote: ... >> >> Let's remove the OPTIONS ASS (for libass) entry AND let's simply >> depend on multimedia/libass. >> >> It is simple and fulfills every criteria: >> >> 1) port is going to build >> >> 2) no option will be ignored >> >> 3) POLA is upheld since the port was built with ASS subtitle >> support before and it will continue to be. The only difference >> is that it will always use an external library instead of the >> internal one. >> >> Let me know what you think. A multimedia/mencoder patch is attached >> as a suggestion. Is this compromise acceptable? > > This would be better than the current state of the port, but I'd > prefer my earlier patch, because multimedia/libass drags in some other > dependencies, among them converters/recode, which I'd rather avoid, > because it has some unpatched bugs, including an overly-wide bitfield > that causes builds with newer versions of gcc to fail. So, specifically, I'm suggesting something like the attached patch, which allows those of us who don't need libass to avoid unnecessary and problematic dependencies, as in your original commit, but avoids overriding user options. It sets the ASS option to be on by default, to address your POLA concerns. It also includes fixes for the other problems with these two ports that I mentioned, portrevision bumps, and your tweaks for the pkgconfig dependency. > > Again, I must ask, what makes you think that the mplayer configure > script is defective? As I said earlier, I cannot reproduce the > problem. Could you provide some more information? And, even if it > is, what prevents us from simply patching it? > > Also, what about fixing the fragile piece of code that I pointed out, > and the enca autodetection? > --bcaec5215d9b45643504a91fa1f9 Content-Type: application/octet-stream; name="mplayer_mencoder_2.diff" Content-Disposition: attachment; filename="mplayer_mencoder_2.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 SW5kZXg6IG1wbGF5ZXIvTWFrZWZpbGUKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2hvbWUvcGN2cy9w b3J0cy9tdWx0aW1lZGlhL21wbGF5ZXIvTWFrZWZpbGUsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu MjA3CmRpZmYgLXUgLXIxLjIwNyBNYWtlZmlsZQotLS0gbXBsYXllci9NYWtlZmlsZQkyMCBKdWwg MjAxMSAwMjo1MjoyMSAtMDAwMAkxLjIwNworKysgbXBsYXllci9NYWtlZmlsZQkyOCBKdWwgMjAx MSAwNToxMjoxMCAtMDAwMApAQCAtNyw3ICs3LDcgQEAKIAogUE9SVE5BTUU9CW1wbGF5ZXIKIFBP UlRWRVJTSU9OPQkke01QTEFZRVJfUE9SVF9WRVJTSU9OfQotUE9SVFJFVklTSU9OPQkyCitQT1JU UkVWSVNJT049CTMKIENPTU1FTlQ9CUhpZ2ggcGVyZm9ybWFuY2UgbWVkaWEgcGxheWVyIHN1cHBv cnRpbmcgbWFueSBmb3JtYXRzCiAKIC5pbmNsdWRlICIkey5DVVJESVJ9L01ha2VmaWxlLnNoYXJl ZCIKQEAgLTUxLDcgKzUxLDcgQEAKIE9QVElPTlMrPQlUSEVPUkEgIkVuYWJsZSBvZ2cgdGhlb3Jh IHZpZGVvIHN1cHBvcnQiIG9mZgogT1BUSU9OUys9CVZQWCAiRW5hYmxlIFZQOCB2aWRlbyB2aWEg bGlidnB4IiBvZmYKIE9QVElPTlMrPQlTQ0hST0VESU5HRVIgIkRpcmFjIGNvZGVjIHZpYSBsaWJz Y2hyb2VkaW5nZXIiIG9mZgotT1BUSU9OUys9CUFTUyAiRW5hYmxlIEFTUy9TU0Egc3VidGl0bGUg cmVuZGVyaW5nIiBPZmYKK09QVElPTlMrPQlBU1MgIkVuYWJsZSBBU1MvU1NBIHN1YnRpdGxlIHJl bmRlcmluZyIgb24KIC5pZiAhZGVmaW5lZChQQUNLQUdFX0JVSUxESU5HKQogT1BUSU9OUys9CVdJ TjMyICJFbmFibGUgd2luMzIgY29kZWMgc2V0IG9uIHRoZSBJQTMyIGFyY2giIG9uCiAuZW5kaWYK QEAgLTc0LDEyICs3NCw2IEBACiAKIENPTkZGSUxFUz0JZXhhbXBsZS5jb25mIGlucHV0LmNvbmYg bWVudS5jb25mIGR2Yi1tZW51LmNvbmYKIAotIyBmaXggZm9yIGJ1ZyB3aGVuIGxpYmFzcyBpcyBp bnN0YWxsZWQsIG1wbGF5ZXIgY29uZmlndXJlIGRvZXMgbm90Ci0jIHVwaG9sZCAtLWRpc2FibGUt YXNzCi0uaWYgZXhpc3RzKCR7TE9DQUxCQVNFfS9saWIvbGliYXNzLnNvKQotV0lUSF9BU1M9CXll cwotLmVuZGlmCi0KIC5pbmNsdWRlIDxic2QucG9ydC5wcmUubWs+CiAKIC5pZiAke0FSQ0h9ID09 ICJzcGFyYzY0IgpAQCAtMTAyLDEwICs5NiwxMCBAQAogCiAuaWYgZGVmaW5lZChXSVRIX0FTUykK IExJQl9ERVBFTkRTKz0JYXNzLjU6JHtQT1JUU0RJUn0vbXVsdGltZWRpYS9saWJhc3MKLVVTRV9H Tk9NRSs9CXBrZ2NvbmZpZworQlVJTERfREVQRU5EUyArPQlwa2ctY29uZmlnOiR7UE9SVFNESVJ9 L2RldmVsL3BrZy1jb25maWcKIExJQkFTU19QS0dDT05GSUdfQ0ZMQUdTPQlwa2ctY29uZmlnIC0t Y2ZsYWdzIC0tc2lsZW5jZS1lcnJvcnMgbGliYXNzCiAuZWxzZQotQ09ORklHVVJFX0FSR1MrPQkt LWRpc2FibGUtYXNzIC0tZGlzYWJsZS1hc3MtaW50ZXJuYWwKK0NPTkZJR1VSRV9BUkdTKz0JLS1k aXNhYmxlLWFzcyAtLWRpc2FibGUtYXNzLWludGVybmFsIC0tZGlzYWJsZS1lbmNhCiBMSUJBU1Nf UEtHQ09ORklHX0NGTEFHUz0JJHtFQ0hPX0NNRH0KIC5lbmRpZgogCkluZGV4OiBtcGxheWVyL2Zp bGVzL3BhdGNoLXN1Yl9fc3VicmVhZGVyLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogbXBsYXllci9m aWxlcy9wYXRjaC1zdWJfX3N1YnJlYWRlci5jCmRpZmYgLU4gbXBsYXllci9maWxlcy9wYXRjaC1z dWJfX3N1YnJlYWRlci5jCi0tLSAvZGV2L251bGwJMSBKYW4gMTk3MCAwMDowMDowMCAtMDAwMAor KysgbXBsYXllci9maWxlcy9wYXRjaC1zdWJfX3N1YnJlYWRlci5jCTIzIEp1bCAyMDExIDAzOjI3 OjUwIC0wMDAwCkBAIC0wLDAgKzEsMTMgQEAKKy0tLSBzdWIvc3VicmVhZGVyLmMub3JpZwkyMDEx LTA3LTIyIDIzOjA4OjUyLjAwMDAwMDAwMCAtMDQwMAorKysrIHN1Yi9zdWJyZWFkZXIuYwkyMDEx LTA3LTIyIDIzOjI2OjE1LjAwMDAwMDAwMCAtMDQwMAorQEAgLTI1MDksOCArMjUwOSwxMCBAQAor ICAgc3RyaXBfbWFya3VwID0gMTsKKyAjZW5kaWYKKyAgIGlmICghc3RyaXBfbWFya3VwKSB7Cisr I2lmZGVmIENPTkZJR19BU1MKKyAgICAgc3ViYXNzY29udmVydF9zdWJyaXAodHh0LCBidWYsIE1B WF9TVUJMSU5FICsgMSk7CisgICAgIHN1Yi0+dGV4dFtzdWItPmxpbmVzXSA9IGJ1ZjsKKysjZW5k aWYgCisgICB9IGVsc2UgeworICAgICBmb3IgKGkgPSAwOyBpIDwgbGVuICYmIHBvcyA8IE1BWF9T VUJMSU5FOyBpKyspIHsKKyAgICAgICBjaGFyIGMgPSB0eHRbaV07CkluZGV4OiBtZW5jb2Rlci9N YWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9wY3ZzL3BvcnRzL211bHRpbWVkaWEv bWVuY29kZXIvTWFrZWZpbGUsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjgKZGlmZiAtdSAtcjEu MjggTWFrZWZpbGUKLS0tIG1lbmNvZGVyL01ha2VmaWxlCTIwIEp1bCAyMDExIDAyOjUyOjM0IC0w MDAwCTEuMjgKKysrIG1lbmNvZGVyL01ha2VmaWxlCTI4IEp1bCAyMDExIDA1OjIzOjQwIC0wMDAw CkBAIC02LDcgKzYsNyBAQAogCiBQT1JUTkFNRT0JbWVuY29kZXIKIFBPUlRWRVJTSU9OPQkke01Q TEFZRVJfUE9SVF9WRVJTSU9OfQotUE9SVFJFVklTSU9OPQkxCitQT1JUUkVWSVNJT049CTIKIENP TU1FTlQ9CUNvbnZlbmllbnQgdmlkZW8gZmlsZSBhbmQgbW92aWUgZW5jb2RlcgogUkVTVFJJQ1RF RD0JUG9ydCBoYXMgcmVzdHJpY3RlZCBkZXBlbmRlbmNpZXMKIApAQCAtNDEsNyArNDEsNyBAQAog T1BUSU9OUys9CVZQWCAiRW5hYmxlIFZQOCB2aWRlbyB2aWEgbGlidnB4IiBvZmYKIE9QVElPTlMr PQlESVJBQyAiRW5hYmxlIGRpcmFjIHZpZGVvIGNvZGVjIHN1cHBvcnQiIG9mZgogT1BUSU9OUys9 CVNDSFJPRURJTkdFUiAiRGlyYWMgY29kZWMgdmlhIGxpYnNjaHJvZWRpbmdlciIgb2ZmCi1PUFRJ T05TKz0JQVNTICJFbmFibGUgQVNTL1NTQSBzdWJ0aXRsZSByZW5kZXJpbmciIE9mZgorT1BUSU9O Uys9CUFTUyAiRW5hYmxlIEFTUy9TU0Egc3VidGl0bGUgcmVuZGVyaW5nIiBvbgogT1BUSU9OUys9 CVJFQUxQTEFZRVIgIkVuYWJsZSByZWFsIHBsYXllciBwbHVnaW4iIG9mZgogT1BUSU9OUys9CUxJ VkVNRURJQSAiRW5hYmxlIExJVkU1NTUgc3RyZWFtaW5nIHN1cHBvcnQiIG9mZgogT1BUSU9OUys9 CVNNQiAiRW5hYmxlIFNhbWJhIGlucHV0IHN1cHBvcnQiIG9mZgpAQCAtNjUsMTIgKzY1LDYgQEAK IAkJcHNuci12aWRlby5zaCBxZXBkdmNkLnNoIHN1YmVkaXQucGwgXAogCQlzdWJzZWFyY2guc2gg dzMyY29kZWNfZGwucGwgd21hMm9nZy5wbCBcCiAKLSMgZml4IGZvciBidWcgd2hlbiBsaWJhc3Mg aXMgaW5zdGFsbGVkLCBtcGxheWVyIGNvbmZpZ3VyZSBkb2VzIG5vdAotIyB1cGhvbGQgLS1kaXNh YmxlLWFzcwotLmlmIGV4aXN0cygke0xPQ0FMQkFTRX0vbGliL2xpYmFzcy5zbykKLVdJVEhfQVNT PQl5ZXMKLS5lbmRpZgotCiAuaW5jbHVkZSA8YnNkLnBvcnQucHJlLm1rPgogCiBMSUJfREVQRU5E Uys9CW1wM2xhbWUuMDoke1BPUlRTRElSfS9hdWRpby9sYW1lCkBAIC05OSwxMCArOTMsMTAgQEAK IAogLmlmIGRlZmluZWQoV0lUSF9BU1MpCiBMSUJfREVQRU5EUys9CWFzcy41OiR7UE9SVFNESVJ9 L211bHRpbWVkaWEvbGliYXNzCi1VU0VfR05PTUUrPQlwa2djb25maWcKK0JVSUxEX0RFUEVORFMg Kz0JcGtnLWNvbmZpZzoke1BPUlRTRElSfS9kZXZlbC9wa2ctY29uZmlnCiBMSUJBU1NfUEtHQ09O RklHX0NGTEFHUz0JcGtnLWNvbmZpZyAtLWNmbGFncyAtLXNpbGVuY2UtZXJyb3JzIGxpYmFzcwog LmVsc2UKLUNPTkZJR1VSRV9BUkdTKz0JLS1kaXNhYmxlLWFzcyAtLWRpc2FibGUtYXNzLWludGVy bmFsCitDT05GSUdVUkVfQVJHUys9CS0tZGlzYWJsZS1hc3MgLS1kaXNhYmxlLWFzcy1pbnRlcm5h bCAtLWRpc2FibGUtZW5jYQogTElCQVNTX1BLR0NPTkZJR19DRkxBR1M9CSR7RUNIT19DTUR9CiAu ZW5kaWYKIAo= --bcaec5215d9b45643504a91fa1f9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGFTUwOU_PXVS4agENXow%2Bm1nzYEL_Qa09ZELwy7xqE=j9HO3w>