From nobody Wed Jun 4 23:03:44 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bCNRk3Qt6z5xmw3; Wed, 04 Jun 2025 23:03:46 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bCNRk2d6jz3nsy; Wed, 04 Jun 2025 23:03:46 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749078226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BZw5uzs5SrXDbn0wLyNaxbUnRETqKK7D3R5siDiRlCw=; b=X1HGpaMPqNUJF5kitMg707H8ZYpS0Bq6cBHOsbsXbgmi5KdJzT0vpLsr+n6OtMrq8nYFVe UMgLxj498ILnIzU9z4xaaUYBqiuiOtT2y3mJVDMJEGyM5Z5q/xjwLnfRxgBvb3E/PErpe6 rRNYKfF7sVUHqPgh6iuvVRteWC1h1ZW7Xk+dXqBYhSgzBBFhmVRm3TIe5L+1aF1d6cLAO9 a98c+xJqqsLvSNXcLavpisT98nKiZOnRIkF1qq3Sw5d1QiYSewr2gxUr5QJ226NWNSAbjY 6hzIrflUOzFrGu0HPi0I/bVDG1jX98/3UevqkhXqpKeQjQt/hAhHBs9RTRVTsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749078226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BZw5uzs5SrXDbn0wLyNaxbUnRETqKK7D3R5siDiRlCw=; b=tdoDO8lMJGyl90EQ2wvBwOTlaghhlDBGCOeM0mowNVd32kHRqUe1ipm5sAbv169YaiGY2Z J2orsN8J7EJLDmeCzZp7812TBRRx7IEharth8KaClFipLsbEoSCE7SS9gaz/9xJ/EB5hzH HkXwZAalq6IBqNdXMX+ABpMQgzBkGw2yCFh4WmZ0ijKs+SZGwStxDPU2zi/FqrJWMh0uJc AIPyEJUrZzAw8NRDmZ9ypjfIN6TpQ7Yad+S/Akk88/a+/KjSRdEwO92Fprn8UjJNeXUkMg 3/PWF0dSTp817i7QoSzdcqwkEbjcA3FwqVkOt98aM3wiPtvsl8kBTeLOtfn3pw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749078226; a=rsa-sha256; cv=none; b=GTO1THXZIp1m2Fyob7e/ExqeQP9lVrfXa83bjGPKd3DzceJ8aAoidlhIyeBu9bUIdxv5mB Q2yVxva3zKeqABPNLMMV4EBwuDUN1kxVzWdfi0/FecziTLKB9G0DFih73CNRlTiEUZXiW9 CDaeUnBTuwjf31BWxtjrS8K/GghLtan0LLoKtdm8Ib+aIW63tCH1KMlp3v5ujtuuLHgvaG ev6YCLRNj4YtrzKo1KIa9I7/YMgN1N8Bo2TDop/3+ZuLMO/n6oPgb37pwyAzfpvyiKIyLm dHxdgsJsYMtC8HV89bFZASi6PYQVgHlUHEt/3C58OvCQuVNuzPm3it69NokKqw== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bCNRj66llzmgh; Wed, 04 Jun 2025 23:03:45 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <02ed6d30-b22a-456d-96e2-7f5b235766fd@FreeBSD.org> Date: Wed, 4 Jun 2025 18:03:44 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 969f6380eb66 - main - kdump: nicer printing of kill(2) PID argument To: Gleb Smirnoff , markj@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202506040151.5541pESm016476@gitrepo.freebsd.org> Content-Language: en-US From: Kyle Evans In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/4/25 17:55, Gleb Smirnoff wrote: > On Wed, Jun 04, 2025 at 01:51:14AM +0000, Kyle Evans wrote: > K> The branch main has been updated by kevans: > K> > K> URL: https://cgit.FreeBSD.org/src/commit/?id=969f6380eb66f809eed3e5c38b6021824a4cc2bf > K> > K> commit 969f6380eb66f809eed3e5c38b6021824a4cc2bf > K> Author: Kyle Evans > K> AuthorDate: 2025-06-04 01:51:06 +0000 > K> Commit: Kyle Evans > K> CommitDate: 2025-06-04 01:51:06 +0000 > K> > K> kdump: nicer printing of kill(2) PID argument > K> > K> Similar to wait*(), kill(2) operates on a pid that currently gets output > K> as hex. Output it in decimal to make it a little easier to eyeball the > K> pid we're signalling. > K> > K> Reviewed by: markj > K> Differential Revision: https://reviews.freebsd.org/D50508 > > I didn't review if PIDs are always printed as decimals or not, but for > the file descriptors it is a mix of hex and decimals. :( Usually I go > with a sed script over kdump output to make it consistent. > To be fair, I'd like to fix that, too- I noticed close() the other day for fd > 0, but paused when I: 1.) couldn't tell where we even output close args 2.) noticed that close_range has the same problem, but hex can make sense for its upper range (particularly when you're doing ~0U to simulate closefrom(2)) and that's a bit of a predicament because that's a harder pattern to spot in decimal. > I think if we try to bring that to common format, that would leave > some people unsatisfied regardless of our choice - all decimal or > all hex. > > So, I would suggest to add a command line options that would force > into all hex or all decimal. > I'd like to hear from some folks that prefer hex here... other system tools are generally not printing IDs in hex, so it makes it harder to correlate. Ideally, I think we'd audit it all and make sure we match truss(1) here (which tends to just print decimal for all of the ID arguments, as far as I've found).