From owner-cvs-src@FreeBSD.ORG Sat Aug 12 18:25:44 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 141E516A4DA; Sat, 12 Aug 2006 18:25:44 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D3EED43D45; Sat, 12 Aug 2006 18:25:43 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from freefall.freebsd.org (yar@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k7CIPhuX043189; Sat, 12 Aug 2006 18:25:43 GMT (envelope-from yar@freefall.freebsd.org) Received: (from yar@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k7CIPhdj043187; Sat, 12 Aug 2006 18:25:43 GMT (envelope-from yar) Date: Sat, 12 Aug 2006 18:25:43 +0000 From: Yar Tikhiy To: Sam Leffler Message-ID: <20060812182543.GA39872@freefall.freebsd.org> References: <200607090610.k696AO6E061602@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200607090610.k696AO6E061602@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/ifconfig ifclone.c ifconfig.c ifconfig.h ifvlan.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Aug 2006 18:25:44 -0000 On Sun, Jul 09, 2006 at 06:10:24AM +0000, Sam Leffler wrote: > sam 2006-07-09 06:10:23 UTC > > FreeBSD src repository > > Modified files: > sbin/ifconfig ifclone.c ifconfig.c ifconfig.h ifvlan.c > Log: > o replace special handling of clone operations by a clone callback > mechanism > o change vlan cloning to use callback and pass all vlan parameters > on create using the new SIOCREATE2 ioctl > o update vlan set logic to match existing practice > > Revision Changes Path > 1.2 +35 -21 src/sbin/ifconfig/ifclone.c > 1.120 +12 -23 src/sbin/ifconfig/ifconfig.c > 1.18 +2 -2 src/sbin/ifconfig/ifconfig.h > 1.12 +78 -54 src/sbin/ifconfig/ifvlan.c Excuse me for noticing this late, but this change broke command lines that had used to work, e.g: # ifconfig vlan77 create vlan 77 vlandev xl0 mtu 1006 up ifconfig: ioctl (set mtu): Device not configured ifconfig: ioctl (SIOCGIFFLAGS): no such interface My experience summarized in ifvlan.c rev. 1.11 showed that using callbacks in ifconfig could be tricky because the order of processing command-line parameters was important in some common cases. -- Yar