Date: Thu, 29 Jan 2015 00:23:46 -0800 From: John-Mark Gurney <jmg@funkthat.com> To: Dimitry Andric <dim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r277860 - head/usr.sbin/sa Message-ID: <20150129082346.GC27103@funkthat.com> In-Reply-To: <201501282222.t0SMMoHU095511@svn.freebsd.org> References: <201501282222.t0SMMoHU095511@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Dimitry Andric wrote this message on Wed, Jan 28, 2015 at 22:22 +0000:
> Replace the VERSION_KEY define with a writable char array, so no const
> qualifier needs to be dropped anymore.
You do realize that you should juse use __DECONST for this instead?
This moves the data from .rodata into .data making it writable, and
also means that bad programs could end up stop working, instead of
faulting when someone tries to change the version string...
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150129082346.GC27103>