From owner-cvs-src@FreeBSD.ORG  Sun Mar 21 11:46:56 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 618)
	id D282416A4CF; Sun, 21 Mar 2004 11:46:55 -0800 (PST)
In-Reply-To: <200403171750.i2HHoujf059824@repoman.freebsd.org> from Nate
	Lawson at "Mar 17, 2004 09:50:56 am"
To: njl@FreeBSD.org (Nate Lawson)
Date: Sun, 21 Mar 2004 11:46:55 -0800 (PST)
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-Id: <20040321194655.D282416A4CF@hub.freebsd.org>
From: wpaul@FreeBSD.ORG (Bill Paul)
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/amd64/isa atpic.c src/sys/contrib/dev/oltr
	if_oltr.c src/sys/dev/aac aac_pci.c src/sys/dev/acpica/Os
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Mar 2004 19:46:56 -0000

> njl         2004/03/17 09:50:55 PST
> 
>   FreeBSD src repository
> 
>   Modified files:
[...]
>     sys/dev/if_ndis      if_ndis_pccard.c if_ndis_pci.c 
[...]
>   Log:
>   Convert callers to the new bus_alloc_resource_any(9) API.
>   
>   Submitted by:   Mark Santcroos <marks@ripe.net>
>   Reviewed by:    imp, dfr, bde

:(

By doing this, you have fixed it to people can't use the NDISulator
code on 5.2-RELEASE or 5.2.1-RELEASE. I think it is hardly worth it
to break source code compatibility in this case just to avoid having
to type a few extra arguments. At the very least, bus_alloc_resource_any()
could have been implemented as a macro: then I could just test for its
existence and #define it myself so the code would run on older systems.
I'm very susprised that bde never raised this point.

I have no choice now but to revert if_ndis_pci.c and if_ndis_pccard.c
back to the old API to un-break it for 5.2-REL and 5.2.1-REL users.
Thanks a whole lot, people.

-Bill

--
=============================================================================
-Bill Paul            (510) 749-2329 | Senior Engineer, Master of Unix-Fu
                 wpaul@windriver.com | Wind River Systems
=============================================================================
              <adamw> you're just BEGGING to face the moose
=============================================================================