From owner-freebsd-bugs@FreeBSD.ORG Wed Dec 13 08:00:22 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8011816A403 for ; Wed, 13 Dec 2006 08:00:22 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3478243CC6 for ; Wed, 13 Dec 2006 07:58:54 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id kBD80JrU084472 for ; Wed, 13 Dec 2006 08:00:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id kBD80J5K084467; Wed, 13 Dec 2006 08:00:19 GMT (envelope-from gnats) Resent-Date: Wed, 13 Dec 2006 08:00:19 GMT Resent-Message-Id: <200612130800.kBD80J5K084467@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Dr. Markus Waldeck" Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5322B16A4FB for ; Wed, 13 Dec 2006 07:54:43 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [69.147.83.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9B61643C9E for ; Wed, 13 Dec 2006 07:49:13 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id kBD7ofxg055123 for ; Wed, 13 Dec 2006 07:50:41 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id kBD7oe1M055122; Wed, 13 Dec 2006 07:50:40 GMT (envelope-from nobody) Message-Id: <200612130750.kBD7oe1M055122@www.freebsd.org> Date: Wed, 13 Dec 2006 07:50:40 GMT From: "Dr. Markus Waldeck" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.0 Cc: Subject: kern/106657: src/sys/netinet/udp_usrreq.c should contain a sufficient comment about net.inet.udp.checksum X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2006 08:00:22 -0000 >Number: 106657 >Category: kern >Synopsis: src/sys/netinet/udp_usrreq.c should contain a sufficient comment about net.inet.udp.checksum >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: doc-bug >Submitter-Id: current-users >Arrival-Date: Wed Dec 13 08:00:18 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Dr. Markus Waldeck >Release: 7.0-CURRENT-200611 >Organization: >Environment: FreeBSD fbh 7.0-CURRENT-200611 FreeBSD 7.0-CURRENT-200611 root@fb:/usr/src/sys/i386/compile/FB70B01 i386 >Description: I tried to figure out what is the purpose of net.inet.udp.checksum. I found in src/sys/netinet/udp_usrreq.c following lines #ifndef COMPAT_42 static int udpcksum = 1; #else static int udpcksum = 0; /* XXX */ #endif I expect that net.inet.udp.checksum is a 4.2BSD compatibility feature. But /* XXX */ is NOT a very sufficient comment! >How-To-Repeat: less src/sys/netinet/udp_usrreq.c >Fix: add a useful comment >Release-Note: >Audit-Trail: >Unformatted: