From owner-freebsd-current@FreeBSD.ORG Sun Oct 7 14:21:45 2007 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8D90E16A49A; Sun, 7 Oct 2007 14:21:45 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247]) by mx1.freebsd.org (Postfix) with ESMTP id 4D43813C46E; Sun, 7 Oct 2007 14:21:44 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 3DD00668D86; Sun, 7 Oct 2007 16:02:42 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nhOotuT6BG59; Sun, 7 Oct 2007 16:02:38 +0200 (CEST) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 575A0668D6F; Sun, 7 Oct 2007 16:02:38 +0200 (CEST) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id l97E2cto044832; Sun, 7 Oct 2007 16:02:38 +0200 (CEST) (envelope-from rdivacky) Date: Sun, 7 Oct 2007 16:02:37 +0200 From: Roman Divacky To: current@freebsd.org Message-ID: <20071007140237.GA44735@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.3i Cc: peter@freebsd.org Subject: pad argument for mmap/lseek/etc. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2007 14:21:45 -0000 hi 3 months ago Peter Wemm removed "pad" argument from mmap/lseek/etc. syscalls arguments. Unfortunately he forgot to update the struct XYZ_args definitions shipped with the actual functions like this: vm/vm_mmap.c: #ifndef _SYS_SYSPROTO_H_ struct mmap_args { void *addr; size_t len; int prot; int flags; int fd; long pad; off_t pos; }; #endif /* * MPSAFE */ int mmap(td, uap) struct thread *td; struct mmap_args *uap; it would be nice to get this removed. I'd submit a patch but I dont know what syscalls this affected. thnx roman