From nobody Sat Jun 10 07:06:14 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QdTWW4gStz4cGss for ; Sat, 10 Jun 2023 07:06:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QdTWV6jjvz3qNm for ; Sat, 10 Jun 2023 07:06:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1686380774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6yJG9BWT6Ga4bFmy1pkgQD7FrEGPncEqDKcAz4rCxTM=; b=iBmuXTzOXli39mlgMQsdUz59Kg6oKNx+vRiSUIxvwhl30yYJ21H0j6SHQ8c0fkReciPbsE w4MVNry0TGH7j5HNvmnt7trsGjPI9uI1QQJZdn9XunRKwYqgzTA0ebFjGc219Cxcxczwis OpnuA7PSLXllJO0r0CP4vNwaT8xLeTJM7FQTPZt1EIcV6VUzSiryziXpy49ZzXn5WN1iIL TKu8iNa6W+wsupSQLuR0uy3bqLMm1jIyoPhrL9YykY/9WQgri3Z09sHwZUOXpjOZxUPQWb IxfJrSHqEX4ubMsF8ML8szyV58UGS/0UQVWDVMaTbn6/xUmnNgvYbMtaYPgDLQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1686380774; a=rsa-sha256; cv=none; b=dTzFZgFvUh0jouVm8BptxdDyEz450FY7MoV1G3kt7gH8kQ9qKBaomnBXiEBWXo3QmcBpSM sD8p3Qhz8GMJj28Oj+gwAn/sbm5dloyT8A/c0p6wPk60FLGCpjvOU0oxq5dFkfMAyhXNRE Tm83XNmcyneibEDjUxneEQuRLkUduq/o8jgiw+4EvTtNE+OZna9HE50YVwRZGeqmuYQB9q QW4WIn5PXcqKiBG73k6F00311g/FsgLpPLVQFDkqd+OqnYgg5J67FQ8qzr/9Cw+iVEr/K4 Esals0XfqNoES87sYcvCIsAAqtkiHUlvnktlVh8sPo8LXJjslGL/jGj2rkLMqg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QdTWV5md0z16yq for ; Sat, 10 Jun 2023 07:06:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 35A76EZn052534 for ; Sat, 10 Jun 2023 07:06:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 35A76EQJ052533 for bugs@FreeBSD.org; Sat, 10 Jun 2023 07:06:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 271925] chflags(1) fails to remove uarch flag with hardlinked files (ZFS) Date: Sat, 10 Jun 2023 07:06:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: se@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271925 Stefan E=C3=9Fer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |se@FreeBSD.org --- Comment #1 from Stefan E=C3=9Fer --- Created attachment 242708 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D242708&action= =3Dedit Update stat info of file to be changed This seems to be caused by ZFS collecting multiple flag updates and by effectively mapping the setting of flags to toggling of flags. I'm not sure that I fully understand the complex mapping of attributes in sys/module/os/freebsd/zfs/zfs_vnops_os.c (line 4888ff), but I guess that the second call sees that the new attributes are identical to the (already alte= red) current attributes of the file and then marks it to not need a vnode update= on stable storage. Anyway, the attached simple patch fixes the issue on ZFS. I chose to update= the flags in place instead of in a separate stat structure. --=20 You are receiving this mail because: You are the assignee for the bug.=