From owner-cvs-all@FreeBSD.ORG  Mon Oct 10 14:10:55 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id CE15816A420; Mon, 10 Oct 2005 14:10:55 +0000 (GMT)
Date: Mon, 10 Oct 2005 14:10:55 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Renato Botelho <garga@FreeBSD.org>
Message-ID: <20051010141055.GA17353@FreeBSD.org>
References: <200510101327.j9ADRXJL014167@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200510101327.j9ADRXJL014167@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/games/galaxyhack Makefile
	ports/games/galaxyhack/files patch-Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Oct 2005 14:10:56 -0000

On Mon, Oct 10, 2005 at 01:27:31PM +0000, Renato Botelho wrote:
> garga       2005-10-10 13:27:31 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     games/galaxyhack     Makefile 
>     games/galaxyhack/files patch-Makefile 
>   Log:
>   o Fix wrong patch in "files" directory and convert DOS to UNIX text files in
>     post-extract.

CR/LF -> LF conversion is somewhat suboptimal: by doing -exec, find(1)
spawns ${REINPLACE_CMD} (and probably ${ECHO_CMD}, but this one is cheap
since it's a shell builtin) on every file it finds.  Correct way would
be to use xargs(1), as mentioned in section ``4.4 Patching'' of Porter's
Handbook.

./danfe