From owner-svn-src-head@freebsd.org Thu Oct 5 06:30:27 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2004E2E0A0; Thu, 5 Oct 2017 06:30:27 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 4389623E8; Thu, 5 Oct 2017 06:30:25 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id JAA17538; Thu, 05 Oct 2017 09:30:24 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1dzzfs-000LyI-04; Thu, 05 Oct 2017 09:30:24 +0300 Subject: Re: svn commit: r324178 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua From: Andriy Gapon To: Ed Maste Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" References: <201710012012.v91KCUvU024559@repo.freebsd.org> <73fc56c3-2a00-44a4-9d3c-5ff77053ddf6@FreeBSD.org> Message-ID: <1daf8629-7c80-5b43-3d8e-31a925b44538@FreeBSD.org> Date: Thu, 5 Oct 2017 09:29:27 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <73fc56c3-2a00-44a4-9d3c-5ff77053ddf6@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 06:30:27 -0000 On 04/10/2017 23:29, Andriy Gapon wrote: > On 04/10/2017 23:08, Ed Maste wrote: >> On 1 October 2017 at 22:12, Andriy Gapon wrote: >>> >>> Author: avg >>> Date: Sun Oct 1 20:12:30 2017 >>> New Revision: 324178 >>> URL: https://svnweb.freebsd.org/changeset/base/324178 >>> >>> Log: >>> unbreak kernel builds on sparc64 and powerpc after r324163, ZFS Channel Programs >> >> Seems this is still broken on sparc64: >> https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/1443/console > > That's really puzzling because I specifically tested the fix on sparc64 before > committing and it worked. > > Oh, I see, you meant powerpc64... Now I see where I tripped. The code built fine on sparc64 and powerpc does not build ZFS at all and powerpc64 (with char unsigned) kept failing. I am going to commit a platform independent fix soon. -- Andriy Gapon