From owner-freebsd-stable Wed Jun 17 17:33:06 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id RAA12634 for freebsd-stable-outgoing; Wed, 17 Jun 1998 17:33:06 -0700 (PDT) (envelope-from owner-freebsd-stable@FreeBSD.ORG) Received: from cesit1.unifi.it (cesit1.unifi.it [150.217.1.31]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA12623 for ; Wed, 17 Jun 1998 17:32:58 -0700 (PDT) (envelope-from ugo@dsi.UNIFI.IT) Received: from aguirre.dsi.unifi.it by CESIT1.UNIFI.IT (PMDF V5.1-10 #23168) with SMTP id <01IYD6GLPGYE00027J@CESIT1.UNIFI.IT> for freebsd-stable@FreeBSD.ORG; Thu, 18 Jun 1998 02:32:58 MET Received: from dsi.unifi.it (ppp-firenze71-90.iol.it) by aguirre.dsi.unifi.it (4.1/SMI-4.1) id AA20865; Thu, 18 Jun 1998 02:34:00 +0200 Received: from pegasus.home.net (pegasus.home.net [192.168.1.3]) by dsi.unifi.it (8.8.8/8.8.8) with ESMTP id OAA07362; Wed, 17 Jun 1998 14:25:07 +0200 (MET DST envelope-from ugo) Received: (from ugo@localhost) by pegasus.home.net (8.8.8/8.8.8) id OAA00446; Wed, 17 Jun 1998 14:25:04 +0200 (MET DST envelope-from ugo) Date: Wed, 17 Jun 1998 14:25:04 +0200 (MET DST) From: Ugo Paternostro Subject: Re: PnP support for if_ed, and more... In-reply-to: <199806131854.LAA00693@antipodes.cdrom.com> To: Mike Smith Cc: Luigi Rizzo , freebsd-stable@FreeBSD.ORG, eivind@yes.no (Eivind Eklund) Message-id: Organization: Not an organization MIME-version: 1.0 X-Mailer: XFMail 1.2 [p0] on FreeBSD Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Priority: 3 (Normal) Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 13-Jun-98 Mike Smith wrote about "Re: PnP support for if_ed, and more...": >> that I should avoid mixing the diffs togheter. What do you suggest? > > You're correct that the two should be separate. Luigi has commit > access now I think, and failing that Eivind has practice in that area... I'm sorry to say that Luigi doesn't want to have commit privs... I'm talking to Eivind about committing the patches, no problems. (BTW, Eivind, will you receive any copy of what gnats notes about a PR now that you're responsible for it?) >> Should I fix/remove bogus/useless Vendor IDs from if_ed.c and sio.c? > > Yes. [...snip...] > If you don't have it, err on the side of caution. (That's kinda > obvious, really 8) I will just remove the WSC9008 id that I added (and that I still can test), but I will leave the SupraExpress ID. I have one more question: in sio.c I found this definition: #define EXTRA_SIO 2 while in -current if_ed.c I found: #define EXTRA_ED 8 Shouldn't it be better to have #define EXTRA_SIO MAX_PNP_CARDS In both sources? It is _theorically_ possible to have 8 (MAX_PNP_CARDS) PnP cards of the same type, so why should we be ready for that? I propose to change both definitions. Unlucky, we have to move them after the "#include " line... FYI we (Luigi and me) agreed to change the return value of the xxxpnp_probe routines to avoid probing twice if the LDN is disabled (i.e.: now the routine returns a NULL pointer if the ID is unknown, a pointer to a null string if the LDN is disabled and a pointer to a non null string otherwise). > \\ Sometimes you're ahead, \\ Mike Smith Bye, UP To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message