Date: Sun, 27 Jun 2004 23:44:53 -0400 From: John Baldwin <jhb@FreeBSD.org> To: freebsd-ia64@FreeBSD.org Cc: Arun Sharma <arun@FreeBSD.org> Subject: Re: Clobbering foreign partitions Message-ID: <200406272344.53886.jhb@FreeBSD.org> In-Reply-To: <20040627071931.GA25902@sharma-home.net> References: <20040627071931.GA25902@sharma-home.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 27 June 2004 03:19 am, Arun Sharma wrote: > libdisk seems to have a bug which causes it to corrupt the GPT table in the > presence of foreign partitions. > > Description: > > Consider a GPT with the following partitions: > > - EFI system (da0p1) > - Linux (da0p2) > > When libdisk opens the disk and creates a list of chunks, it ignores > da0p2, because it's an "unknown" type. In other words, there is only > one chunk. The rest is "unused". > > Subsequently, sysinstall doesn't display da0p2 (which I think is ok), > but allows the user to create a FreeBSD partition on da0p2. > > I think the intended behavior is to ignore foreign partitions in > sysinstall UI, but take care not to clobber them in Write_Disk(). > > The attached patch changes the policy on ia64 only and correctly handles > the above situation. > > -Arun Looks ok to me. Marcel, do you think you can test this? -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406272344.53886.jhb>