From owner-freebsd-ia64@FreeBSD.ORG Mon Jun 28 03:44:08 2004 Return-Path: Delivered-To: freebsd-ia64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3271316A4CF for ; Mon, 28 Jun 2004 03:44:08 +0000 (GMT) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id D90FA43D31 for ; Mon, 28 Jun 2004 03:44:07 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 8116 invoked from network); 28 Jun 2004 03:44:07 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 28 Jun 2004 03:44:07 -0000 Received: from 131.106.56.214 (p58.n-nypop02.stsn.com [199.106.89.58]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i5S3hg8m098960; Sun, 27 Jun 2004 23:43:58 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: freebsd-ia64@FreeBSD.org Date: Sun, 27 Jun 2004 23:44:53 -0400 User-Agent: KMail/1.6 References: <20040627071931.GA25902@sharma-home.net> In-Reply-To: <20040627071931.GA25902@sharma-home.net> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406272344.53886.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Arun Sharma Subject: Re: Clobbering foreign partitions X-BeenThere: freebsd-ia64@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting FreeBSD to the IA-64 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2004 03:44:08 -0000 On Sunday 27 June 2004 03:19 am, Arun Sharma wrote: > libdisk seems to have a bug which causes it to corrupt the GPT table in the > presence of foreign partitions. > > Description: > > Consider a GPT with the following partitions: > > - EFI system (da0p1) > - Linux (da0p2) > > When libdisk opens the disk and creates a list of chunks, it ignores > da0p2, because it's an "unknown" type. In other words, there is only > one chunk. The rest is "unused". > > Subsequently, sysinstall doesn't display da0p2 (which I think is ok), > but allows the user to create a FreeBSD partition on da0p2. > > I think the intended behavior is to ignore foreign partitions in > sysinstall UI, but take care not to clobber them in Write_Disk(). > > The attached patch changes the policy on ia64 only and correctly handles > the above situation. > > -Arun Looks ok to me. Marcel, do you think you can test this? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org