Date: Thu, 30 Jul 2015 13:05:07 -0700 From: Benno Rice <benno@FreeBSD.org> To: Larry Rosenman <ler@lerctr.org> Cc: freebsd-current@freebsd.org Subject: Re: pmspcv panic on boot on this box Message-ID: <765D2BB8-F101-4D8C-BF1D-BB896904FB29@FreeBSD.org> In-Reply-To: <04E640B9-423C-4C30-BF90-D3DD148C930D@FreeBSD.org> References: <20150728210109.GA6424@oldtbh.lerctr.org> <04E640B9-423C-4C30-BF90-D3DD148C930D@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_E69A5EF7-5BB4-4D4B-A0E8-1D8922E43E7C
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=us-ascii
Can you try the attached patch and let me know if it fixes the issue?
Many thanks,
Benno.
--Apple-Mail=_E69A5EF7-5BB4-4D4B-A0E8-1D8922E43E7C
Content-Disposition: attachment;
filename=pmspcv.diff
Content-Type: application/octet-stream;
name="pmspcv.diff"
Content-Transfer-Encoding: 7bit
Index: sys/dev/pms/freebsd/driver/common/lxutil.c
===================================================================
--- sys/dev/pms/freebsd/driver/common/lxutil.c (revision 286083)
+++ sys/dev/pms/freebsd/driver/common/lxutil.c (working copy)
@@ -758,6 +758,7 @@
int idx;
static U32 cardMap[4] = { 0, 0, 0, 0 };
u_int16_t agtiapi_dev; // PCI device ID
+ u_int16_t agtiapi_vendor; // PCI vendor ID
AGTIAPI_PRINTK("agtiapi_ProbeCard: start\n");
if ( ! atomic_cmpset_32( &cardMap[thisCard], 0, 5 ) ) { // card already ran
@@ -766,10 +767,12 @@
}
else {
agtiapi_dev = pci_get_device( dev ); // get PCI device ID
+ agtiapi_vendor = pci_get_vendor( dev ); // get PCI vendor ID
for( idx = 0; idx < COUNT(ag_card_type); idx++ )
{
- if( ag_card_type[idx].deviceId == agtiapi_dev )
- { // device ID match
+ if( ag_card_type[idx].deviceId == agtiapi_dev &&
+ ag_card_type[idx].vendorId == agtiapi_vendor )
+ { // device and vendor IDs match
memset( (void *)&agCardInfoList[ thisCard ], 0,
sizeof(ag_card_info_t) );
thisCardInst->cardIdIndex = idx;
--Apple-Mail=_E69A5EF7-5BB4-4D4B-A0E8-1D8922E43E7C
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=utf-8
> On Jul 30, 2015, at 11:55 AM, Benno Rice <benno@freebsd.org> wrote:
>=20
> Hi Larry,
>=20
> I=E2=80=99ve brought this to the attention of PMC Sierra and we=E2=80=99=
re pretty sure we=E2=80=99ve worked out what the problem is. I=E2=80=99m =
just waiting on their review of the fix I=E2=80=99ve suggested.
>=20
> Sorry this has caused you problems.
>=20
> Many apologies,
> Benno.
>=20
>> On Jul 28, 2015, at 2:01 PM, Larry Rosenman <ler@lerctr.org> wrote:
>>=20
>> When I upgraded an approximately 3 month old -CURRENT system to =
yesterday, I=20
>> got page not present panics, after a message about pmspcv not =
supporting
>> my ahd(4) deviceid.=20
>>=20
>> I did NOT capture the panic, but adding
>>=20
>> nodevice pmspcv
>>=20
>> Allowed me to boot.=20
>>=20
>> Dmesg.boot from the WORKING system attached.=20
>>=20
>> I *CAN* work with someone if they want.=20
>>=20
>>=20
>> <dmesg.boot>_______________________________________________
>> freebsd-current@freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-current
>> To unsubscribe, send any mail to =
"freebsd-current-unsubscribe@freebsd.org"
>=20
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to =
"freebsd-current-unsubscribe@freebsd.org"
--Apple-Mail=_E69A5EF7-5BB4-4D4B-A0E8-1D8922E43E7C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?765D2BB8-F101-4D8C-BF1D-BB896904FB29>