From owner-freebsd-current@FreeBSD.ORG  Mon Mar  1 14:13:42 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9161216A4CE
	for <current@freebsd.org>; Mon,  1 Mar 2004 14:13:42 -0800 (PST)
Received: from ms-smtp-01-eri0.ohiordc.rr.com
	(ms-smtp-01-smtplb.ohiordc.rr.com [65.24.5.135])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 38BAC43D3F
	for <current@freebsd.org>; Mon,  1 Mar 2004 14:13:42 -0800 (PST)
	(envelope-from dzerkel@columbus.rr.com)
Received: from columbus.rr.com (dhcp065-024-164-116.columbus.rr.com
	[65.24.164.116])i21MDbMV019821;	Mon, 1 Mar 2004 17:13:38 -0500 (EST)
Message-ID: <4043B5A1.4070008@columbus.rr.com>
Date: Mon, 01 Mar 2004 17:13:53 -0500
From: "Danny J. Zerkel" <dzerkel@columbus.rr.com>
User-Agent: Mozilla Thunderbird 0.5 (X11/20040301)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Peter Schultz <pmes@bis.midco.net>
References: <404399A6.8080303@columbus.rr.com>
	<4043B404.9000304@bis.midco.net>
In-Reply-To: <4043B404.9000304@bis.midco.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Symantec AntiVirus Scan Engine
cc: current@freebsd.org
Subject: Re: Mozilla problems on current -- fix
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Mar 2004 22:13:42 -0000

Peter Schultz wrote:
> Danny J. Zerkel wrote:
> 
>> Looks like John's sys/kern/kern_thread.c 1.171 broke Mozilla (and
>> threading in general).  He appears to have left out a test that
>> the sleeping thread is interruptable in one spot:
>>
>> --- kern_thread.c.orig  Mon Mar  1 15:08:01 2004
>> +++ kern_thread.c       Mon Mar  1 14:26:30 2004
>> @@ -646,7 +646,8 @@
>>                 } else if (TD_ON_SLEEPQ(td2) &&
>>                            ((td2->td_wchan == &kg->kg_completed) ||
>>                             (td2->td_wchan == &p->p_siglist &&
>> -                            (ku->ku_mflags & KMF_WAITSIGEVENT)))) {
>> +                            (ku->ku_mflags & KMF_WAITSIGEVENT))) &&
>> +                             (td2->td_flags & TDF_SINTR)) {
>>                         sleepq_abort(td2);
>>                 } else {
>>                         ku->ku_flags |= KUF_DOUPCALL;
>>
>> This change fixes my Mozilla hangs and other panics on current.
>>
> 
> Do you have ULE and ADAPTIVE_MUTEXES in your kernel conf?
> 
> Thanks,
> Pete...
> 
Pete,

I do not have ULE on.  I do have ADAPTIVE_MUTEXES on.

Danny Zerkel
dzerkel@columbus.rr.com