From owner-svn-src-head@FreeBSD.ORG  Thu Jan 23 09:59:27 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 493C727D;
 Thu, 23 Jan 2014 09:59:27 +0000 (UTC)
Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id E1B98196A;
 Thu, 23 Jan 2014 09:59:26 +0000 (UTC)
Received: from srg.kevlo.org (mail.kevlo.org [220.135.115.6])
 by ns.kevlo.org (8.14.6/8.14.6) with ESMTP id s0N9dVV0003376;
 Thu, 23 Jan 2014 17:39:31 +0800 (CST)
 (envelope-from kevlo@FreeBSD.org)
Message-ID: <52E0E36E.2070509@FreeBSD.org>
Date: Thu, 23 Jan 2014 17:39:58 +0800
From: Kevin Lo <kevlo@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Hans Petter Selasky <hselasky@FreeBSD.org>
Subject: Re: svn commit: r261014 - head/sys/dev/usb/wlan
References: <201401220957.s0M9vQfY070899@svn.freebsd.org>
In-Reply-To: <201401220957.s0M9vQfY070899@svn.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jan 2014 09:59:27 -0000


On 2014/01/22 17:57, Hans Petter Selasky wrote:
> Author: hselasky
> Date: Wed Jan 22 09:57:26 2014
> New Revision: 261014
> URL: http://svnweb.freebsd.org/changeset/base/261014
>
> Log:
>    - Fix some non-portable code with regard to endianness. Don't use memmove().
>    - Fix a range check for maximum transmit length.
>    - Fix read from missing field when transmitting data.
>    
>    MFC after:	2 weeks

I appreciate you're taking the time to fix code, but your change totally
breaks RT3573 and IQ calibration doesn't work for RT5372 and RT5572.
I think it'd be good to send me the patch for testing/review
before committing.  Thanks!

     Kevin