From owner-cvs-all@FreeBSD.ORG  Mon Jan 16 18:50:43 2012
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 344F81065672;
	Mon, 16 Jan 2012 18:50:43 +0000 (UTC)
	(envelope-from makc@freebsd.org)
Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3])
	by mx1.freebsd.org (Postfix) with ESMTP id 5E2EA8FC0A;
	Mon, 16 Jan 2012 18:50:41 +0000 (UTC)
Received: from mercury.ph.man.ac.uk [130.88.75.175:56174] (HELO/EHLO
	mercury.ph.man.ac.uk, authenticated with LOGIN)
	by mail.issp.ac.ru with ESMTP/inet id q0GIdFqY026029 (using TLSv1/SSLv3,
	with cipher DHE-RSA-AES256-SHA (256 bits), verified NO)
	Mon, 16 Jan 2012 21:39:15 +0300 (MSK)
From: Max Brazhnikov <makc@freebsd.org>
To: Ruslan Mahmatkhanov <rm@freebsd.org>
Date: Mon, 16 Jan 2012 18:38:12 +0000
User-Agent: KMail/1.13.7 (FreeBSD/9.0-RC1; KDE/4.7.3; amd64; ; )
References: <201201130338.q0D3cMgJ018062@repoman.freebsd.org>
In-Reply-To: <201201130338.q0D3cMgJ018062@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_U6GFPpKEjlBiHbb"
Message-Id: <201201161838.12941.makc@freebsd.org>
Cc: cvs-ports@freebsd.org, Veniamin Gvozdikov <g.veniamin@googlemail.com>,
	Axel Gonzalez <loox@e-shell.net>, cvs-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: cvs commit: ports/audio/clementine-player Makefile
	ports/audio/clementine-player/files patch-src-devices-cddadevice.h
	patch-src-devices-cddalister.cpp
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jan 2012 18:50:43 -0000

--Boundary-00=_U6GFPpKEjlBiHbb
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit

On Fri, 13 Jan 2012 03:38:22 +0000 (UTC), Ruslan Mahmatkhanov wrote:
> rm          2012-01-13 03:38:22 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     audio/clementine-player Makefile
>   Added files:
>     audio/clementine-player/files patch-src-devices-cddadevice.h
>                                   patch-src-devices-cddalister.cpp
>   Log:
>   - let it build with stock gcc
>   - optionify ipod and mtp support (default on)

This type of `port optionification' leads to a nasty problem of hidden 
dependencies when options are unchecked, but corresponding libraries are 
presented. Please consider to commit the patch, which makes optional support 
really optional.

Max

 
>   PR:             164043
>   Submitted by:   Axel Gonzalez <loox at e-shell dot net>
>   Approved by:    maintainer
> 
>   Revision  Changes    Path
>   1.13      +14 -13    ports/audio/clementine-player/Makefile
>   1.1       +15 -0    
> ports/audio/clementine-player/files/patch-src-devices-cddadevice.h (new)
> 1.1       +16 -0    
> ports/audio/clementine-player/files/patch-src-devices-cddalister.cpp (new)


--Boundary-00=_U6GFPpKEjlBiHbb
Content-Type: text/x-patch; charset="UTF-8"; name="clementine-player.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="clementine-player.diff"

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/audio/clementine-player/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- Makefile	13 Jan 2012 03:38:22 -0000	1.13
+++ Makefile	16 Jan 2012 18:07:01 -0000
@@ -54,14 +54,20 @@
 
 .if defined(WITH_LASTFM)
 LIB_DEPENDS+=	lastfm.0:${PORTSDIR}/audio/liblastfm
+.else
+CMAKE_ARGS+=	-DENABLE_LIBLASTFM=Off
 .endif
 
 .if defined(WITH_GPOD)
 LIB_DEPENDS+=	gpod.7:${PORTSDIR}/audio/libgpod
+.else
+CMAKE_ARGS+=	-DENABLE_LIBGPOD=Off
 .endif
 
 .if defined(WITH_MTP)
 LIB_DEPENDS+=	mtp.11:${PORTSDIR}/audio/libmtp
+.else
+CMAKE_ARGS+=	-DENABLE_LIBMTP=Off
 .endif
 
 .include <bsd.port.post.mk>

--Boundary-00=_U6GFPpKEjlBiHbb--