From owner-freebsd-java@FreeBSD.ORG Tue Mar 20 18:39:22 2012 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 60BA91065674 for ; Tue, 20 Mar 2012 18:39:22 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 1E0DE8FC20 for ; Tue, 20 Mar 2012 18:39:21 +0000 (UTC) Received: by pbcwz17 with SMTP id wz17so291532pbc.13 for ; Tue, 20 Mar 2012 11:39:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-operating-system :organization:x-living-the-dream:x-pgp-fingerprint:x-pgp-key :user-agent:x-gm-message-state; bh=1jRUhIflxcqh5hQGDkklLPYhTFkGO3BeGAC7uTIaLwQ=; b=QPmSBEQ3GWgLbmaNRu18JA1JWmuQU0bp/ZxJ0kG1XqifbRtXc4rOXrlIrTcchxX1kp Lnx1f+bjrxf/h4TDgzsElHJ/V5SsYKtpr9CVGOvhjB/2260jro2dl4qrTLlKdf7OxS/v hAP+7kMlH3BMT4wPGgdwO4sHBNqvFk1gnwAawNtJMKu39DLlnkvIjubUAXtgvGTTzcG9 mM1v+yrcSJx86JuvOFLlCEQ+L4W53GV8wZnRjKrRnsOSjW5Nd8xWSmshzvaAX9GZFEFZ Y3PMvHl3c+JzfB0E490s/lZD2EOgiC5jVHk57EToGFqzywkMDNyxcd4eAuIA+uq8hCgG ukLw== Received: by 10.68.228.67 with SMTP id sg3mr3860731pbc.17.1332268761613; Tue, 20 Mar 2012 11:39:21 -0700 (PDT) Received: from dormouse.experts-exchange.com ([72.29.164.238]) by mx.google.com with ESMTPS id kx17sm1826336pbb.19.2012.03.20.11.39.19 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 20 Mar 2012 11:39:20 -0700 (PDT) Sender: Jason Helfman Date: Tue, 20 Mar 2012 11:38:28 -0700 From: Jason Helfman To: Jung-uk Kim Message-ID: <20120320183828.GB13507@dormouse.experts-exchange.com> References: <20120318180225.GA51618@dormouse.experts-exchange.com> <201203191945.50219.jkim@FreeBSD.org> <20120319235959.GL46825@dormouse.experts-exchange.com> <201203201230.06968.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <201203201230.06968.jkim@FreeBSD.org> X-Operating-System: FreeBSD 8.2-RELEASE amd64 Organization: The FreeBSD Project, http://www.freebsd.org X-Living-The-Dream: I love the SLO Life! X-PGP-FingerPrint: 8E0D C457 9A0F C91C 23F3 0454 2059 9A63 4150 D3DC X-PGP-Key: http://people.freebsd.org/~jgh/jgh.asc User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQlLFFPnfc8rHA8VsZlCg4HRDGivJeNotl+usPHYkEyCdZbztgznuQTdKmF1YuyvouSigmSM Cc: freebsd-eclipse@FreeBSD.org, freebsd-java@FreeBSD.org Subject: Re: [RFC] New Port: Eclipse Java Compiler, java/eclipse-ecj X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2012 18:39:22 -0000 On Tue, Mar 20, 2012 at 12:29:57PM -0400, Jung-uk Kim thus spake: >> I am unable to validate this with the jar that is built. Are you >> able to get it to work? > >No, current port builds unusable ecj.jar. :-( I am able to compile with it with no issue. What issues are you seeing? > >> >While you are at it, please add these: >> > >> >USE_ZIP= yes >> >> Why? It isn't a zip file, and why is this dependency required? > >A JAR file is essentially a ZIP file with additional meta-data, just >like a FreeBSD package is a tarball with meta-data. > >% file /usr/local/openjdk6/jre/lib/rt.jar >/usr/local/openjdk6/jre/lib/rt.jar: Zip archive data, at least v1.0 to >extract > >If you are really concerned about the additiaonal build dependency, >you may use jar but (bsd)tar is the worst choice. Tar is completely valid for uncompressing zip archives. > >> >NO_WRKSUBDIR= yes >> >> Can't see why this would be an issue to put in. >> >> >and remove these: >> > >> >BUILD_WRKSRC= ${WRKDIR} >> >> Why? Otherwise, I need to put: >> WRKSRC= ${WRKDIR} > >That's because it is easier to read/maintain for maintainer(s), >"FOO=yes" is easier to parse with scripts, it is the "official" ports >way to handle this case, etc, etc... Scripts can still parse and find both WRKDIR and WRKSRC in this port regardless of the option I use. If BUILD_WRKSRC is not easier, why is it bpm? I am also confused by this. What would I be setting to yes, to resolve this issue? > >bsd.port.mk: ># NO_WRKSUBDIR - Assume port unpacks directly into ${WRKDIR}. It does do this, and I have made this change, but haven't pushed it yet, as I would like to work out the style issue first. > >> Seems silly when bpm supports a different BUILD worksource. > >I am sorry but I don't understand this because I don't use bpm. I am referring to bsd.port.mk > >> >... >> >EXTRACT_CMD= ${TAR} >> >EXTRACT_BEFORE_ARGS= xf >> >EXTRACT_AFTER_ARGS= -C ${WRKDIR} >> >> Why on these, as well? I'm not using zip, and zip is in different >> locations based on different releases of the Operating System. > >Please see above. Besides, what made you think bsdtar is available >and able extract a JAR file on "different releases of the Operating >System"? ;-) There are instances of using zip that don't work on 7.x with jar files. I have addressed this in a number of ports as a result of pointyhat failures. Thanks, Jason -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh