From owner-cvs-ports@FreeBSD.ORG  Wed Feb  1 07:59:00 2006
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
X-Original-To: cvs-ports@freebsd.org
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7F6E516A420;
	Wed,  1 Feb 2006 07:59:00 +0000 (GMT)
	(envelope-from dougb@freebsd.org)
Received: from rwcrmhc14.comcast.net (rwcrmhc14.comcast.net [204.127.192.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CB87943D45;
	Wed,  1 Feb 2006 07:58:59 +0000 (GMT)
	(envelope-from dougb@freebsd.org)
Received: from [192.168.1.101] (70-32-110-40.vnnyca.adelphia.net[70.32.110.40])
	by comcast.net (rwcrmhc14) with ESMTP
	id <20060201075859m1400mv0sie>; Wed, 1 Feb 2006 07:58:59 +0000
Message-ID: <43E06A42.2030200@FreeBSD.org>
Date: Tue, 31 Jan 2006 23:58:58 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 1.5 (X11/20060112)
MIME-Version: 1.0
To: ports-committers@FreeBSD.org,  cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org
References: <200601301402.k0UE2oKX097948@repoman.freebsd.org>
	<43E00A62.8090908@FreeBSD.org>
In-Reply-To: <43E00A62.8090908@FreeBSD.org>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: cvs commit: ports/comms/conserver-com Makefile distinfo
 pkg-plist
 ports/comms/conserver-com/files conserver.sh conserver.sh.in
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Feb 2006 07:59:00 -0000

Doug Barton wrote:
> Jun Kuriyama wrote:
>> kuriyama    2006-01-30 14:02:49 UTC
>>
>>   FreeBSD ports repository
>>
>>   Modified files:
>>     comms/conserver-com  Makefile distinfo pkg-plist 
>>   Added files:
>>     comms/conserver-com/files conserver.sh.in 
>>   Removed files:
>>     comms/conserver-com/files conserver.sh 
>>   Log:
>>   - Upgrade to 8.1.13.
>>   - Improve $USE_RC_SUBR usage.
> 
> Overall this looks good, thanks! One nit though, it is no longer necessary
> to include the FreeBSD KEYWORD, as rc.subr doesn't need it. On the other
> hand, since I believe that this port is responsible for starting a daemon,
> it should probably include 'REQUIRE: DAEMON', and the shutdown KEYWORD. I'd
> be happy to make those changes if they are appropriate, just let me know.
> 
> Regards,
> 
> Doug

-- 

    This .signature sanitized for your protection