From owner-freebsd-net@freebsd.org Wed Sep 12 17:53:46 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1A0C10994DE for ; Wed, 12 Sep 2018 17:53:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 467018C3DB for ; Wed, 12 Sep 2018 17:53:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 082E510994DB; Wed, 12 Sep 2018 17:53:46 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EAF9C10994DA for ; Wed, 12 Sep 2018 17:53:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8C3528C3D1 for ; Wed, 12 Sep 2018 17:53:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id DA50114651 for ; Wed, 12 Sep 2018 17:53:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w8CHriIn056072 for ; Wed, 12 Sep 2018 17:53:44 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w8CHriqG056071 for net@FreeBSD.org; Wed, 12 Sep 2018 17:53:44 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 231151] ifconfig: unable to disable rxcsum, rxcsum6 and vlanhwcsum on em driver Date: Wed, 12 Sep 2018 17:53:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: shurd@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2018 17:53:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D231151 --- Comment #8 from Stephen Hurd --- (In reply to Kaho Toshikazu from comment #7) > the variable setmask should be also masked by isc_capabilities, I think.= =20 Everything going into setmask should be masked by mask already... I've got = that fixed in my patch now, will update right away. > No, it is not broken.=20 I meant in the existing code, not in your patch. I'm trying to figure out = why the old code was forcing only IFCAP_WOL_MCAST|IFCAP_WOL_MAGIC if any WoL fl= ag (including IFCAL_WOL_UCAST) was set. If a driver requires something like this, and the isc_capabilities isn't en= ough to restrict it, there needs to be a flag, a callback, or at least an update= to some manpages regarding it. It's almost certainly better to set the WoL capabilities as specified and have some not work then it is to not allow so= me to be specified at all or to change what set is enabled. > But the Wol feature doesn't have any effect until shutdown or suspend tim= e, and set flags only and avoid re-initialization. Yeah, that part is good. We may actually want a larger set of things that don't reinit. > The vlan_hwcsum is simply forgot in the definition IFCAP_FLAGS.=20 You also moved the if_vlancap(ifp) line to after the reinit. I'm trying to figure out if it should be set while the interface is stopped. It currently doesn't really make a difference as far as I can tell, but it may make sens= e to update while the interface is down, but then the context will be locked. --=20 You are receiving this mail because: You are the assignee for the bug.=