From owner-freebsd-bugs  Mon Aug 12 17:40: 8 2002
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7A7E837B400
	for <freebsd-bugs@hub.freebsd.org>; Mon, 12 Aug 2002 17:40:05 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 377A743E65
	for <freebsd-bugs@hub.freebsd.org>; Mon, 12 Aug 2002 17:40:05 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g7D0e4JU049383
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 12 Aug 2002 17:40:05 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g7D0e4pH049382;
	Mon, 12 Aug 2002 17:40:04 -0700 (PDT)
Date: Mon, 12 Aug 2002 17:40:04 -0700 (PDT)
Message-Id: <200208130040.g7D0e4pH049382@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Brad Johnson <bjohnson@got.wedgie.org>
Subject: Re: bin/41482: pkg_info core-dumps for old style +CONTENTS file
Reply-To: Brad Johnson <bjohnson@got.wedgie.org>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR bin/41482; it has been noted by GNATS.

From: Brad Johnson <bjohnson@got.wedgie.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc: iwaki@bc.niigata-u.ac.jp
Subject: Re: bin/41482: pkg_info core-dumps for old style +CONTENTS file
Date: Mon, 12 Aug 2002 20:35:24 -0400 (EDT)

 Hm... silly me...
 
 In my "fix" of this problem by setting p->origin to NULL in lib/plist.c, I
 fixed the seg fault, but I also broke the -o functionality of
 pkg_info!!
 
 The initialization of origin should happen at the beginning of the
 read_plist function, not add_plist as I originally suggested. I made the
 fix on mine and pkg_info started working the way it was supposed to
 without core dumps.
 
 So on line 263 of lib/plist.c, I added:
 
 pkg->origin = NULL;
 
 Sorry for not picking that up earlier; it was my first time looking at the
 code.
 
 - Brad Johnson
 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message