From owner-svn-src-head@freebsd.org Thu Jun 1 06:06:38 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A77E1B79D38; Thu, 1 Jun 2017 06:06:38 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 753A8649E5; Thu, 1 Jun 2017 06:06:38 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x241.google.com with SMTP id f27so6714681pfe.0; Wed, 31 May 2017 23:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=iLeso6bHhTujEVy9zuJ6kt5CO1rYEnX2xmduDQM/x80=; b=bEFbLlYkxBk9542J+ctlL3tOqrfGVW2uBKHKh7vJ9ycibySZdWop5iKLYOl9fUjgZ+ XJ1lbUc+kJKQGCbnG5queV0GyuSqN04xGiiLKoL3SWBmeqfbNbfIkb0XxlZ7coCPFs2T F2fqlhAs78OhFAFcSolmBGdtW7sO0+4rF8H7oAsVGkm45YAcI5LtvoPvkqjlNH+e3Ypu h74eJOP+y8MTh7u0Eb0wTEZa9OjuDNdTANvUN00YqzXNFb9NI5h0E+8Q9Dr7PLdbUFIt UgX9AlLhe0B/j9rGcrKLO+81gj4Oo0w6psCWA2bk8uTVUGuENggrGhLamxwJ7NvmP23E 7x0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=iLeso6bHhTujEVy9zuJ6kt5CO1rYEnX2xmduDQM/x80=; b=VE1b5BmA0mEhwrmGSu/W4tblKr+ifFNomKTWt1zAuz64B0XUOQMCET2t9pZysbNdzX sf0nc6NmXTDa4sNeiyd3TYKTOXLEQFopC5pIFWwowmZSvKgywG6I3cMFEnJPaisQDppX Z99CU2PeStzkdKp7nhH3MsEol1HOByig9z41eOvGCF2xQ8juAGnrjY3SvXRPAD9XBRs5 eKJhHXQ+AlRrY5SdGKJJnyEcxn9Y/JLr3TneZalJ0fJ9kPowNVTgZtAmYU/0GWRQl27P RSBBogRiEWfkVZoNy2YxneIwOYalRrW8SCqoFJIjqH5PH5y7eMyfZfIxVFCQF7JByA2+ 9G6Q== X-Gm-Message-State: AODbwcDi54SgY/spnWqedUxlWnZpEIJAGi8NYiBEIruIbjs4V5rkdCTC frvOpYoawkidTcUtLs4= X-Received: by 10.98.19.206 with SMTP id 75mr34496057pft.208.1496297197773; Wed, 31 May 2017 23:06:37 -0700 (PDT) Received: from fuji-wireless.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id f86sm32096191pfj.128.2017.05.31.23.06.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2017 23:06:37 -0700 (PDT) From: "Ngie Cooper (yaneurabeya)" Message-Id: <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> Content-Type: multipart/signed; boundary="Apple-Mail=_DA06CB10-94EA-4DD7-B34D-674163D3BACC"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Date: Wed, 31 May 2017 23:06:50 -0700 In-Reply-To: <20170601050339.GA48398@spindle.one-eyed-alien.net> Cc: Ngie Cooper , Marcel Moolenaar , "Simon J. Gerraty" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Brooks Davis References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> X-Mailer: Apple Mail (2.3273) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 06:06:38 -0000 --Apple-Mail=_DA06CB10-94EA-4DD7-B34D-674163D3BACC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On May 31, 2017, at 10:03 PM, Brooks Davis wrote: >=20 > On Wed, May 31, 2017 at 08:01:12AM +0000, Ngie Cooper wrote: >> Author: ngie >> Date: Wed May 31 08:01:12 2017 >> New Revision: 319295 >> URL: https://svnweb.freebsd.org/changeset/base/319295 >>=20 >> Log: >> Update the usr.bin/mkimg golden test output files after = ^/head@r319125 >>=20 >> ^/head@r319125 changed the location of the backup pmbr, requiring = the >> output files to be regenerated, since they're binary disk dumps. >>=20 >> The output files were regenerated with "make rebase"--fixed in >> ^/head@r319294. >=20 > These should not be stored uuencoded. It serves no purpose other > than bloating the repo and causing spammy commit mails like this one > where we got a huge tail of garbage output. Hi Brooks, I=E2=80=99m not entirely sure why the files were uuencoded to be = honest. I think that=E2=80=99s a good question for Marcel and some of = the folks at Juniper, since they wrote the tool/tests. Thanks! -Ngie PS I agree based on what little I know, but I don=E2=80=99t necessarily = know what trade offs were made with writing these tests. --Apple-Mail=_DA06CB10-94EA-4DD7-B34D-674163D3BACC Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJZL676AAoJEPWDqSZpMIYVaFEP/0TYeegYaOrr06PMIZWAILpK GSU+tTobSMU4CBEkyQaUuQACCcvytTaeRwDItpspCTUP97A5vHADDKgV9onBBp2f RSLiWaE23EQ1X+auLQOkm8ihKic8fvLQhlpXxCDyVanguByhn8LaIv2rMnWiADbF pdWPvi8mkmg+wO1c/uhJGjs7Wy/QTw5XVljBmd+d10ElKpWUGam5SL2FVuyA42Yh NPp6Jz+4CdpYpt89+O2FGdX3ZiUSIprOODNesPWzEHCIBfDBU2FnYipZZzDa1acD /j/T4msKUfNT4zQwGXS72yf57gEsgUY8LNzZ2Xx2JGZ+TrKKBgA79P3zZsgMOF7E nL2Fg/7bNxElfAP1jdb4rOBEY7F23tEZsLHGXIDIW1d6dBf5Cowao2vv+EpKVC8l QRSWflLEAw3zqGLj2s58aJjJUj16VmmYb3hBkdp9rNw/o7vJn5VsIcz336OpJ8LA s/NbJoSmPsnj8zPkHqu1gOTNj38jQu87Pm+asWG3u2Dfr5eYJ+FZi/A1BmI4ikPD +mCjwKfUt1luYeue9sWw/ouzV9GMomuEDllXOhAl9fB2nOtR6hciOfKyx7BNfnAW kFff7F9wuuddRU/pFpawuIsHZ/4nh3lf9G9JLbiAauDtUm+y45sHZrwbvnjDGWxd Ko9D8ZKiZKRFU9RcRDfp =5SHd -----END PGP SIGNATURE----- --Apple-Mail=_DA06CB10-94EA-4DD7-B34D-674163D3BACC--