From nobody Tue Feb 24 09:54:05 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fKtNX09p9z6TbTX; Tue, 24 Feb 2026 09:54:20 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4fKtNW3LMjz3wM6; Tue, 24 Feb 2026 09:54:19 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 61O9s5hp066211; Tue, 24 Feb 2026 11:54:08 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 61O9s5hp066211 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 61O9s5Qn066210; Tue, 24 Feb 2026 11:54:05 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 24 Feb 2026 11:54:05 +0200 From: Konstantin Belousov To: Kyle Evans Cc: Mitchell Horne , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0d3652f67d24 - main - sched_shim: Drop the no-ifunc case Message-ID: References: <6984c635.1e072.359146aa@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.2 X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on tom.home X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4fKtNW3LMjz3wM6 X-Spamd-Bar: ---- On Mon, Feb 23, 2026 at 09:10:24PM -0600, Kyle Evans wrote: > On 2/5/26 10:32, Mitchell Horne wrote: > > The branch main has been updated by mhorne: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=0d3652f67d246348e2c017205c6782caf4484449 > > > > commit 0d3652f67d246348e2c017205c6782caf4484449 > > Author: Mitchell Horne > > AuthorDate: 2026-02-05 16:12:03 +0000 > > Commit: Mitchell Horne > > CommitDate: 2026-02-05 16:32:16 +0000 > > > > sched_shim: Drop the no-ifunc case > > Now all architectures support kernel ifunc resolvers. Therefore, the > > alternate implementation can be removed. > > Reviewed by: kib > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D55114 > > --- > > sys/kern/sched_shim.c | 8 -------- > > 1 file changed, 8 deletions(-) > > > > Hi, > > I'm trying to mentally reconcile the commit message with the diff... shouldn't we have kept the `DEFINE_IFUNC` version if all architectures now support ifunc resolvers? To the naked eye it looks like we removed the ifunc bits instead of the non-ifunc bits. > You are right, thank you for noting. Will you fix it? > Thanks, > > Kyle Evans > > > diff --git a/sys/kern/sched_shim.c b/sys/kern/sched_shim.c > > index 83e4412494d3..2b1dcecda433 100644 > > --- a/sys/kern/sched_shim.c > > +++ b/sys/kern/sched_shim.c > > @@ -22,20 +22,12 @@ > > const struct sched_instance *active_sched; > > -#ifndef __DO_NOT_HAVE_SYS_IFUNCS > > -#define __DEFINE_SHIM(__m, __r, __n, __p, __a) \ > > - DEFINE_IFUNC(, __r, __n, __p) \ > > - { \ > > - return (active_sched->__m); \ > > - } > > -#else > > #define __DEFINE_SHIM(__m, __r, __n, __p, __a) \ > > __r \ > > __n __p \ > > { \ > > return (active_sched->__m __a); \ > > } > > -#endif > > #define DEFINE_SHIM0(__m, __r, __n) \ > > __DEFINE_SHIM(__m, __r, __n, (void), ()) > > #define DEFINE_SHIM1(__m, __r, __n, __t1, __a1) \ > >