From owner-cvs-all@FreeBSD.ORG Fri Nov 9 00:56:32 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5900416A417; Fri, 9 Nov 2007 00:56:32 +0000 (UTC) (envelope-from dwhite@gumbysoft.com) Received: from carver.gumbysoft.com (carver.gumbysoft.com [66.220.23.50]) by mx1.freebsd.org (Postfix) with ESMTP id 4518113C4BD; Fri, 9 Nov 2007 00:56:31 +0000 (UTC) (envelope-from dwhite@gumbysoft.com) Received: by carver.gumbysoft.com (Postfix, from userid 1000) id DE0B472DD9; Thu, 8 Nov 2007 16:25:52 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by carver.gumbysoft.com (Postfix) with ESMTP id D76FF72DD7; Thu, 8 Nov 2007 16:25:52 -0800 (PST) Date: Thu, 8 Nov 2007 16:25:52 -0800 (PST) From: Doug White To: "David E. O'Brien" In-Reply-To: <200711081721.lA8HLpXj071345@repoman.freebsd.org> Message-ID: <20071108162438.S86188@carver.gumbysoft.com> References: <200711081721.lA8HLpXj071345@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c ffs_balloc.c ffs_inode.c ffs_snapshot.c ffs_softdep.c ffs_vnops.c src/sys/ufs/ufs ufs_bmap.c ufs_lookup.c ufs_vnops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2007 00:56:32 -0000 This commit does not compile. This is a system with INVARIANTS (and DIAGNOSTIC for that matter) disabled. cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mcmodel=kernel -mno-red-zone -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Werror /usr/src/sys/ufs/ffs/ffs_softdep.c cc1: warnings being treated as errors /usr/src/sys/ufs/ffs/ffs_softdep.c: In function 'initiate_write_inodeblock_ufs1': /usr/src/sys/ufs/ffs/ffs_softdep.c:3877: warning: unused variable 'prevlbn' /usr/src/sys/ufs/ffs/ffs_softdep.c: In function 'initiate_write_inodeblock_ufs2': /usr/src/sys/ufs/ffs/ffs_softdep.c:4020: warning: unused variable 'prevlbn' *** Error code 1 On Thu, 8 Nov 2007, David E. O'Brien wrote: > obrien 2007-11-08 17:21:51 UTC > > FreeBSD src repository > > Modified files: > sys/ufs/ffs ffs_alloc.c ffs_balloc.c ffs_inode.c > ffs_snapshot.c ffs_softdep.c ffs_vnops.c > sys/ufs/ufs ufs_bmap.c ufs_lookup.c ufs_vnops.c > Log: > Turn most ffs 'DIAGNOSTIC's into INVARIANTS. > > Revision Changes Path > 1.148 +17 -17 src/sys/ufs/ffs/ffs_alloc.c > 1.51 +2 -2 src/sys/ufs/ffs/ffs_balloc.c > 1.109 +3 -3 src/sys/ufs/ffs/ffs_inode.c > 1.137 +1 -1 src/sys/ufs/ffs/ffs_snapshot.c > 1.213 +19 -22 src/sys/ufs/ffs/ffs_softdep.c > 1.174 +5 -5 src/sys/ufs/ffs/ffs_vnops.c > 1.67 +1 -1 src/sys/ufs/ufs/ufs_bmap.c > 1.84 +1 -1 src/sys/ufs/ufs/ufs_lookup.c > 1.293 +6 -6 src/sys/ufs/ufs/ufs_vnops.c > -- Doug White | FreeBSD: The Power to Serve dwhite@gumbysoft.com | www.FreeBSD.org