From owner-p4-projects@FreeBSD.ORG Thu Oct 18 01:48:40 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id E525216A421; Thu, 18 Oct 2007 01:48:39 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 868B716A41A for ; Thu, 18 Oct 2007 01:48:39 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outL.internet-mail-service.net (outL.internet-mail-service.net [216.240.47.235]) by mx1.freebsd.org (Postfix) with ESMTP id 7230113C465 for ; Thu, 18 Oct 2007 01:48:39 +0000 (UTC) (envelope-from julian@elischer.org) Received: from mx0.idiom.com (HELO idiom.com) (216.240.32.160) by out.internet-mail-service.net (qpsmtpd/0.40) with ESMTP; Wed, 17 Oct 2007 18:48:38 -0700 X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (nat.ironport.com [63.251.108.100]) by idiom.com (Postfix) with ESMTP id C565C126729; Wed, 17 Oct 2007 18:48:37 -0700 (PDT) Message-ID: <4716BB87.1040004@elischer.org> Date: Wed, 17 Oct 2007 18:48:55 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.6 (Macintosh/20070728) MIME-Version: 1.0 To: Marko Zec References: <200710172258.l9HMw33S061205@repoman.freebsd.org> In-Reply-To: <200710172258.l9HMw33S061205@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Perforce Change Reviews Subject: Re: PERFORCE change 127639 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2007 01:48:40 -0000 Marko Zec wrote: > http://perforce.freebsd.org/chv.cgi?CH=127639 > > Change 127639 by zec@zec_tpx32 on 2007/10/17 22:57:48 > > Introduce a few macros for easier and more readable fetching > of virtualized resource context from a ptr to a proc or thread. > > The additional benefit is that if we ever decide not to hang > vimage / vnet etc. from struct ucred but use some other > method instead, we won't have to change hundreds of lines of > code, but only those few new macros... I see this sort of thing many times.. > + INIT_VPROCG(TD_TO_VPROCG(curthread)); > > + INIT_VPROCG(TD_TO_VPROCG(curthread)); > > + INIT_VNET_NET(TD_TO_VNET(curthread)); > + INIT_VNET_NET(TD_TO_VNET(curthread)); > > + INIT_VNET_NET(TD_TO_VNET(td)); > + INIT_VPROCG(TD_TO_VPROCG(td)); > + INIT_VPROCG(TD_TO_VPROCG(td)); > + INIT_VPROCG(TD_TO_VPROCG(curthread)); /* XXX */ > + INIT_VPROCG(TD_TO_VPROCG(curthread)); > + INIT_VPROCG(TD_TO_VPROCG(curthread)); > + INIT_VPROCG(TD_TO_VPROCG(curthread)); /* XXX */ > > + INIT_VPROCG(TD_TO_VPROCG(curthread)); > + INIT_VPROCG(TD_TO_VPROCG(curthread)); > might not they be further macroised as: #define VNET_FROM_TD(_td) INIT_VNET_NET(TD_TO_VNET(_td)) #define VPROCG_FROM_TD(_td) INIT_VPROCG(TD_TO_VPROCG(_td)) etc. not a requirement.. just a comment. >