From owner-svn-ports-all@freebsd.org Mon Aug 3 09:05:52 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8A5D63738F2; Mon, 3 Aug 2020 09:05:52 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BKsS039Tfz4WWD; Mon, 3 Aug 2020 09:05:52 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MBP-WLAN.fritz.box (p200300cd5f2774003952df9ca87f7c32.dip0.t-ipconnect.de [IPv6:2003:cd:5f27:7400:3952:df9c:a87f:7c32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 94AD826CD6; Mon, 3 Aug 2020 09:05:51 +0000 (UTC) (envelope-from se@freebsd.org) Subject: Re: svn commit: r543919 - head/astro/xearth/files To: Mathieu Arnold , Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <202008011830.071IUpJC086718@repo.freebsd.org> <20200803075524.tvfjcaxbbdd7lwgo@aching.in.mat.cc> <20200803080034.GA74839@FreeBSD.org> <20200803080504.3kzs5n7iapg7sajb@aching.in.mat.cc> From: Stefan Esser Autocrypt: addr=se@freebsd.org; keydata= mQENBFVxiRIBCADOLNOZBsqlplHUQ3tG782FNtVT33rQli9EjNt2fhFERHIo4NxHlWBpHLnU b0s4L/eItx7au0i7Gegv01A9LUMwOnAc9EFAm4EW3Wmoa6MYrcP7xDClohg/Y69f7SNpEs3x YATBy+L6NzWZbJjZXD4vqPgZSDuMcLU7BEdJf0f+6h1BJPnGuwHpsSdnnMrZeIM8xQ8PPUVQ L0GZkVojHgNUngJH6e21qDrud0BkdiBcij0M3TCP4GQrJ/YMdurfc8mhueLpwGR2U1W8TYB7 4UY+NLw0McThOCLCxXflIeF/Y7jSB0zxzvb/H3LWkodUTkV57yX9IbUAGA5RKRg9zsUtABEB AAG0J1N0ZWZhbiBFw59lciAoRnJlZUJTRCkgPHNlQGZyZWVic2Qub3JnPokBVAQTAQoAPgIb AwULCQgHAwUVCgkICwUWAwIBAAIeAQIXgBYhBKNx6mWcC+zIK3FTE0frte9a/fVEBQJa8u+q BQkLJQETAAoJEEfrte9a/fVEOeMH/icmdK1eZQvB3U8quJo9VMaZsaTuCMbUE4NThyfsIvIm MCd+rb/yULmMYwqNfjyKB1x4ikR4x+94l+yJoz7K0Usks+eNKDmMGJM6pWWssTigaJubFdVd hVVC+C1QJi7JshYSib08uONoPmO4lv5Az0TDYGtsMzsES2sIlc62c9go5WPGYhQFRbX3Lk6y V6m8OHh+G9XGSj3oPO4UteRwu+SzTdOLunZBWG1wu34+IeZm663D+2gOppQLWpLa2qaTerqw THu377ayZ2B2LPJ5JkvkZeHYPkwDQ+b5PGn0UhfkxPnDVYki5F7qKxvQ5uq1/q9YaCX7mmOl H2yO7tgVsrW5AQ0EVXGJEgEIALEj9qCXMZVucjpcd3QxM/TlUr98m5viEd1z4tCnPUyRWcIC EVtj2h5xMH+2iB0q1+KWhq+NsWtvScmEmfHnsr7dJ1K677OdpDhKVaJk61eeRulFY1R4yb6C 1MMxK+WgYB+vvpG0UeyR0M4uBewcPvRsq4yGUHFQKtLAbMdoPTSryJA+ElnmK1vdY+rPcHgi OIMBZM7ahsPXC0C9K4e5SP9clGyIoMpbfHXdx9q+Rp3zVtlbhyk3BS/xccu/+9pk9ICXL6GR js2sNnJ0wxdU1DsAlC59a5MnSruwiZFwRnkQhr3x6wk97Lg7sLS9jjTnCN7LGlVmSmpOEMy6 uq1AWfUAEQEAAYkBPAQYAQoAJgIbDBYhBKNx6mWcC+zIK3FTE0frte9a/fVEBQJa8u+rBQkL JQEZAAoJEEfrte9a/fVEuesH/2DNxGWnHvWwMyiyhlQtafvDKwEn/wAgR8gHJFodB7emf8rA TnukH7MVttCoHtjN5lvv9RSBHjNTZls5wR/ANlwdRuPQHd8ZGxLe3S6IuUB3zDSwFltLGurO N2kOMhs5mTGyypSa+uw3rtQbUAVYf1oPbiR4FLtiM8FLyEvE95hX5fPq9Qvx9FmN79kmCIEw jDKPqDaUf/OR2fEF0LSIbXHEk4tNqCEwx5DIJ0fp5/z5UzICUAmwxyRs5O/Hre1jzPsMVyud Ml9t7UTOJGKVWwRory1PMnOFxN+iz5/d4FhYSKXF7kfMiFgol4LuWaxJRwbBrr71VGBrRy2a L1nw6Bc= Message-ID: <2a54f09c-2ed7-336d-2535-0fddfb0826de@freebsd.org> Date: Mon, 3 Aug 2020 11:05:47 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200803080504.3kzs5n7iapg7sajb@aching.in.mat.cc> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2020 09:05:52 -0000 Am 03.08.20 um 10:05 schrieb Mathieu Arnold: > On Mon, Aug 03, 2020 at 08:00:34AM +0000, Alexey Dokuchaev wrote: >> On Mon, Aug 03, 2020 at 09:55:24AM +0200, Mathieu Arnold wrote: >>> On Sat, Aug 01, 2020 at 06:30:51PM +0000, Stefan E?er wrote: >>>> New Revision: 543919 >>>> URL: https://svnweb.freebsd.org/changeset/ports/543919 >>>> >>>> Log: >>>> Fix format: 2 missing commas after the longitude and white space in the >>>> name fields >>> >>> Space in the name fields are there so that names not in the same >>> location but close to one another do not overlap. I am not sure >>> removing them is a great idea. >> >> Abusing spaces for that matter is wrong; the port should be fixed instead >> of relying on manual alignment with spaces. >> >> Please do not taint raw data with its physical representation gimmicks. > > When given the choice between spending 5 seconds adding 3 spaces to make > it look good, or spending a day fixing antique software, I will always > choose 5 seconds (as I don't know C that much, or X programming at all, > it would be more like at least a week). The blanks have been added back in r544041, but I could not check the visual appearance since I'm currently connected over a SSH session without the possibility to start a local X11 server. > If you have the time to fix xearth, feel free to do it, but do not > assume people will have the time, will, or knowledge required to do so. This is an old program and I doubt there is much interest in fixing it - but it might be a relatively simple change and I'll see whether I get to adding an alignment pass after loading the marker data that offsets overloading entries before they are processed for display. That should not be too hard, but it has been (literally) decades since I last have dealt with a plain X11 program ...