From owner-svn-ports-all@freebsd.org Mon Jan 6 05:59:14 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1B88B1F935A; Mon, 6 Jan 2020 05:59:14 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47rlFY5WD6z4GlM; Mon, 6 Jan 2020 05:59:13 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id B4A62D5D1; Mon, 6 Jan 2020 05:59:13 +0000 (UTC) Date: Mon, 6 Jan 2020 05:59:13 +0000 From: Alexey Dokuchaev To: Baptiste Daroussin Cc: Yuri , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r522202 - in head/audio: . libaudec libaudec/files Message-ID: <20200106055913.GA44473@FreeBSD.org> References: <202001060451.0064pfdH044874@repo.freebsd.org> <20200106052719.5oqlohpaadoua3hp@ivaldir.net> <181b91d7-f2dc-750b-a65c-840241aef5b6@rawbw.com> <20200106055041.lggeghkulpm32g3w@ivaldir.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200106055041.lggeghkulpm32g3w@ivaldir.net> User-Agent: Mutt/1.11.4 (2019-03-13) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jan 2020 05:59:14 -0000 On Mon, Jan 06, 2020 at 06:50:41AM +0100, Baptiste Daroussin wrote: > On Sun, Jan 05, 2020 at 09:42:23PM -0800, Yuri wrote: > > On 2020-01-05 21:27, Baptiste Daroussin wrote: > > > It is also a good practice to have a soname for shared library in > > > general. (A soname which is not the name of the .so file itself) > > > > I know, but they didn't assign a soname. You might want to see r423146 as an example[1]. > It is up to the committer to ensure what is packaged is properly packaged, > so if upstream does not provide a SONAME, you should patch the build > system to provide one before adding to the ports tree. Did we ever document this in the PHB? I've found the link above in the 2016 discussion[2] which says that back in those time it had no match for SONAME, had this changed since then? ./danfe [1] https://svnweb.freebsd.org/ports?view=revision&revision=423146 [2] https://lists.freebsd.org/pipermail/freebsd-ports/2016-October/105114.html