Date: Mon, 11 Mar 2019 07:32:31 +0100 From: Tobias Kortkamp <tobik@freebsd.org> To: Koichiro Iwao <meta@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r495326 - in head/textproc/kibana6: . files Message-ID: <20190311063230.GA62788@urd.tobik.me> In-Reply-To: <201903110543.x2B5hKYs027206@repo.freebsd.org> References: <201903110543.x2B5hKYs027206@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 11, 2019 at 05:43:20AM +0000, Koichiro Iwao wrote: > Author: meta > Date: Mon Mar 11 05:43:19 2019 > New Revision: 495326 > URL: https://svnweb.freebsd.org/changeset/ports/495326 >=20 > Log: > textproc/kibana6: Update to 6.5.4 > =20 > While here, > - Quit using ${CHMOD} during do-install, handle permissions in pkg-plist > =20 > PR: 236243 > Submitted by: gettoknowmi <gettoknowmi@yahoo.com> > Reported by: Yuta MASUMOTO <owata@owatan.jp> (plist issue) >=20 > Deleted: > head/textproc/kibana6/files/patch-config_kibana.yml > Modified: > head/textproc/kibana6/Makefile > head/textproc/kibana6/distinfo >=20 > Modified: head/textproc/kibana6/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/textproc/kibana6/Makefile Mon Mar 11 02:32:04 2019 (r495325) > +++ head/textproc/kibana6/Makefile Mon Mar 11 05:43:19 2019 (r495326) > @@ -2,7 +2,7 @@ > # $FreeBSD$ > =20 > PORTNAME=3D kibana > -PORTVERSION=3D 6.4.2 > +PORTVERSION=3D 6.5.4 > DISTVERSIONSUFFIX=3D -linux-x86_64 > PORTREVISION=3D 0 > CATEGORIES=3D textproc www > @@ -35,14 +35,17 @@ do-install: > ${RM} -r config node optimize && \ > ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR}) > ${INSTALL} -lrs ${STAGEDIR}${ETCDIR} ${STAGEDIR}${WWWDIR}/config > - ${CHMOD} +x ${STAGEDIR}${WWWDIR}/bin/* > =20 > post-install: > ${ECHO} "@sample ${ETCDIR}/kibana.yml.sample" >> ${TMPPLIST} > ${FIND} -s ${STAGEDIR}${WWWDIR} -not -type d | ${SORT} | \ > ${SED} -e 's#^${STAGEDIR}${PREFIX}/##' >> ${TMPPLIST} > + ${REINPLACE_CMD} -e "s|\(${WWWDIR}/bin/.*\)|@mode 0755 \1|" ${TMPPLIST} I'm sorry, but this is probably wrong and a noop. There are no entries starting with WWWDIR in TMPPLIST (${PREFIX} is stripped =66rom entries in the ${FIND} line above it). I guess it should be WWWDIR_REL here. @mode also does not take a file argument. Though that problem is of course never triggered. See pkg-create(8): @mode mode Set default permission for all subsequently extracted files to mode. Format is the same as that used by the chmod command. Use without an arg to set back to default (mode of the file while being packed) permissions. As a consequence the scripts no longer have an executable bit set and the package is probably broken at runtime as a result. What was wrong with using CHMOD? --liOOAslEiF7prFVr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAlyGAPxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2EdjQgAnEV2mqefQmDAhUOBS0Hc7hHSqbR2Cy2x/ujBqrRVgz5MyvDBa2ZMMMVZ jQY3gbFj7zvTaj07yBid6K+cFGmTksFpWGusUizfFZH9fH2ZefEpnJkHhcHGRZV1 4ZGcnlFpP6kAgNjbw+y6NLD1Fd7oWipA6X5cO6vbD1pcvmMIzxkcFF9FtYbH6s/R 5C5Ig50Q2D+1AnO/vYZAphAgD+Rh/pUVosS1UemLzl1X9kSotPqWTrR7xCPAqqQu qDxx65wRvnJmnVbwt3y1zaCAXOL3tEvOsP1JgnK/XLxsgcf4czDXrSwXSEbHsn1Y w9OaD9N+BayVXqHddmkMBlXsJwE8Gg== =iqNW -----END PGP SIGNATURE----- --liOOAslEiF7prFVr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190311063230.GA62788>