From owner-freebsd-arch Sat Mar 17 18:16:17 2001 Delivered-To: freebsd-arch@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 4294B37B719; Sat, 17 Mar 2001 18:16:14 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id NAA23100; Sun, 18 Mar 2001 13:15:48 +1100 Date: Sun, 18 Mar 2001 13:15:30 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: "Rodney W. Grimes" Cc: Matt Dillon , John Baldwin , arch@FreeBSD.ORG Subject: Re: Proposal for the CPU interrupt API In-Reply-To: <200103172342.PAA59546@gndrsh.dnsmgr.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 17 Mar 2001, Rodney W. Grimes wrote: > > :and by otherwise I included comments in code. Take this one for example: > > :>From sys/i386/isa/if_sr.c > > : /* > > : * XXX Disable all interrupts for now. I think if you are using the > > : * dmac you don't use these interrupts. > > : */ > > : SRC_PUT8(hc->sca_base, msci->ie0, 0); > > : SRC_PUT8(hc->sca_base, msci->ie1, 0x0C); > > : > > :writting 0x0C to msci->ie1 does NOT disable all interrupts!!! > > > > Well, those XXX's seem to indicate that the author wasn't so sure about > > what he was doing either. Quite a useful comment, I think! > > The XXX is more than likely with regards to the ``I think if you are...'' > part of the comment. (And it is wrong about that as well, you need to > use most of the interrupts, even when using the dmac, to deal with things > like DMA underruns and overruns.) Anyway, this has nothing to do with the subject of this thread. "all" in this context means "all interrupts for this device". Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message