From owner-svn-src-head@freebsd.org Wed Oct 28 16:11:03 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37190A1F680; Wed, 28 Oct 2015 16:11:03 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 1A2661787; Wed, 28 Oct 2015 16:11:03 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 135FB18A6; Wed, 28 Oct 2015 16:11:03 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id CE5431645F; Wed, 28 Oct 2015 16:11:02 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 7n5Q0cDeAbkW; Wed, 28 Oct 2015 16:11:00 +0000 (UTC) Subject: Re: svn commit: r290110 - in head: include lib/libc/stdio DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com A7E3016459 To: Xin Li , "Andrey A. Chernov" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201510281440.t9SEe2PR093917@repo.freebsd.org> <5630EF2F.5080102@delphij.net> From: Bryan Drewery Organization: FreeBSD Message-ID: <5630F390.2070808@FreeBSD.org> Date: Wed, 28 Oct 2015 09:10:56 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5630EF2F.5080102@delphij.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2015 16:11:03 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 10/28/15 8:52 AM, Xin Li wrote: > > On 10/28/15 07:40, Andrey A. Chernov wrote: >> Author: ache Date: Wed Oct 28 14:40:02 2015 New Revision: 290110 >> URL: https://svnweb.freebsd.org/changeset/base/290110 >> >> Log: Add _flags2 per jhb@ suggestion since no room left in >> _flags. Rewrite O_APPEND flag checking using new __S2OAP flag. > > Is this ABI-safe? (I was somewhat surprised that struct FILE is > not opaque, which seems to be unavoidable because some methods are > traditionally macros that have direct access to the members; the > addition is done in the end of the structure so it looks like the > change is safe). Perl reaches in and uses FILE->_file directly even. There's a lot of work behind fixing that case. - -- Regards, Bryan Drewery -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJWMPOQAAoJEDXXcbtuRpfPE1sH/iZRQk+XU9Uh0Ca06RHBRz/d jROUeRLX4ILWopsRHTd/nZ8XE28R9pynxcLeVc5EbX/9eQVyXSx4xAUBkkPag5aw B7HE+15e1fmH5EjmHeL3jW90U501lYLY9H3kwmngonzUXV2f6Rb2Y3DS+YveKWO3 H9KS9bGYt8c6H0fe7IDI7TuscaJ/ihG1GZucr0pM7pArGrO/c/9hO1T4YIO10K1O KseVcy4sMeae5OXos8bGsFvKWzyeQ58q07Y5K3mv2nEr+FhlR+dyOYLaeNLYw3tG p5lxYiT9UVwFvJZvjEiHxLq8NWf/4r59rmcid5xeh2Pl//Etc3fBnuz6l+50HaM= =vQ8q -----END PGP SIGNATURE-----