From owner-svn-src-all@freebsd.org Tue Nov 17 22:49:59 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 57B594719C9; Tue, 17 Nov 2020 22:49:59 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CbLjz1wx7z3qlG; Tue, 17 Nov 2020 22:49:59 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-ed1-f53.google.com with SMTP id t9so24232577edq.8; Tue, 17 Nov 2020 14:49:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Y3qu8Wvw+NvWW7QYTzu/8iW2tJbVuJo3H3UtroIdkMg=; b=IbN+LK6pFJIbg16P9lykNgLPunkC5/yNo2c9IBVrxJDJsgeGoon4L9o5IiX7p9Z0iq V/y+KR+zfYQadkUxZPXZBvunCHUmOJk3Q3TpdcuIKz8MMWdBOKz2XmiItehSyjBhUY+s VpMT/1hEIdOuEsFrGIYSkqVaAfNvuCt0j/sGHv6KqAA01JkDU1iTUTaq/GpxqsP0QPPT EPo9KzDGNNUkdXUxhm0l3zee5gAMFlkKfQqyA8FFQD0aZVDprxkV0FKqduI7V9QnOIxm jYOHx2lc1u+L+/rjKuVnxtAaI6DvbhAFPem9BK8TuGyvayIkEKx8hbBNXP7vF/id7JeZ oKOg== X-Gm-Message-State: AOAM533lQXuIDikzApR+XeRNBSJpbo8fL+AgIqXRfOX7JBSq+I+vDl1/ rGKHqTMDz6noDcInZIwo5cbnC8YUSyk= X-Google-Smtp-Source: ABdhPJwHYUfIOyZpmI3uqcrVI1QpiB+Jz/ceW56jE8Me5S5A/A4KKHlMn63mjOCE5PCvRHJNTwK4Dg== X-Received: by 2002:a05:6402:1f1:: with SMTP id i17mr22676310edy.60.1605653397303; Tue, 17 Nov 2020 14:49:57 -0800 (PST) Received: from ?IPv6:2a02:8109:98c0:1bc0:5e5f:67ff:fef4:ffd8? ([2a02:8109:98c0:1bc0:5e5f:67ff:fef4:ffd8]) by smtp.gmail.com with ESMTPSA id e18sm12080538eja.124.2020.11.17.14.49.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2020 14:49:56 -0800 (PST) Subject: Re: svn commit: r367678 - head/usr.sbin/freebsd-update To: rgrimes@freebsd.org, Kyle Evans Cc: src-committers , svn-src-all , svn-src-head References: <202011172241.0AHMffWK086732@gndrsh.dnsmgr.net> From: Mateusz Piotrowski <0mp@FreeBSD.org> Message-ID: <4f517cd5-703a-2941-2abf-77c22c3c0514@FreeBSD.org> Date: Tue, 17 Nov 2020 23:50:01 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: <202011172241.0AHMffWK086732@gndrsh.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: 4CbLjz1wx7z3qlG X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2020 22:49:59 -0000 On 11/17/20 11:41 PM, Rodney W. Grimes wrote: >> On Sat, Nov 14, 2020 at 11:20 AM Mateusz Piotrowski <0mp@freebsd.org> wrote: >>> On 11/14/20 4:59 PM, Rodney W. Grimes wrote: >>>>> Author: 0mp (doc,ports committer) >>>>> Date: Sat Nov 14 13:07:41 2020 >>>>> New Revision: 367678 >>>>> URL: https://svnweb.freebsd.org/changeset/base/367678 >>>>> >>>>> Log: >>>>> Document the PAGER environment variable >>>>> >>>>> Sometimes users want to use freebsd-update(8) in a non-interactive way and >>>>> what they often miss is that they have to set PAGER to cat(1) in order to >>>>> avoid interactive prompts from less(1). >>>> Which was caused by the change of invoking more(1) as less(1) causing >>>> this regression, as when invoked as more(1) it falls off the end of >>>> empty input and causes no such interactive prompt. >>>> >>>> Setting PAGER to more(1) also fixes this. >>> Mmm, I'm not sure if that would work. If I run "jot 1000 | more" in my terminal I still get an >>> interactive prompt. Could it be that you are referring to a different more(1) implementation? I'm >>> clearly missing something. >>> > Part of what your missing is freebsd-update(8) often outputs a 0 > length file which less(1) well want you to respond Quit to before > going to the next file. more(1) does not do that. Ah, now I see! I forgot about this case. Sure, in this case the old more(1) or the new less(1) with -E are sufficient as well. Thanks a lot, Rodney! I guess that I'll leave the "cat" in the manual for now as it offers fully non-interactive experience. Cheers, Mateusz