From owner-cvs-all@FreeBSD.ORG Mon Oct 10 14:24:39 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A2D7716A41F; Mon, 10 Oct 2005 14:24:39 +0000 (GMT) (envelope-from jmz@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D3AE43D48; Mon, 10 Oct 2005 14:24:39 +0000 (GMT) (envelope-from jmz@FreeBSD.org) Received: from freefall.freebsd.org (jmz@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9AEOd9O086856; Mon, 10 Oct 2005 14:24:39 GMT (envelope-from jmz@freefall.freebsd.org) Received: (from jmz@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9AEOdFW086853; Mon, 10 Oct 2005 14:24:39 GMT (envelope-from jmz) Date: Mon, 10 Oct 2005 14:24:39 GMT Message-Id: <200510101424.j9AEOdFW086853@freefall.freebsd.org> From: Jean-Marc Zucconi To: Alexey Dokuchaev In-Reply-To: <20051010125906.GA3640@FreeBSD.org> References: <200510101133.j9ABXWg4000289@repoman.freebsd.org> <20051010125906.GA3640@FreeBSD.org> X-Mailer: Emacs 21.3.1 Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games/doom Makefile ports/games/doom/files patch-ag patch-sndserv__soundsrv.c patch-sndserv__wadread.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2005 14:24:39 -0000 >>>>> Alexey Dokuchaev writes: > On Mon, Oct 10, 2005 at 11:33:31AM +0000, Jean-Marc Zucconi wrote: >> jmz 2005-10-10 11:33:30 UTC >> >> FreeBSD ports repository >> >> Modified files: >> games/doom Makefile >> games/doom/files patch-ag >> Added files: >> games/doom/files patch-sndserv__soundsrv.c >> patch-sndserv__wadread.c >> Log: > ... >> Replace post-patch with real patch files. > I've always been under impression that we try to avoid creating trivial > patches when desired functionality can be implemented using some > inplace-editing tools. Could you elaborate on what you've done here? I don't know if there is a rule. As the changes are on two files only I decided to not alter the submitted patch and to commit it as is. In either case this will not cause maintenance problems because the port probably will never be upgraded. Jean-Marc -- Jean-Marc Zucconi -- PGP Key: finger jmz@FreeBSD.org [KeyID: 400B38E9]