From nobody Mon Jun 8 19:33:10 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gZ2Jg4jw5z6gcnp for ; Mon, 08 Jun 2026 19:33:23 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gZ2Jg4FKqz3gtX for ; Mon, 08 Jun 2026 19:33:23 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780947203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G/cxXMtWWPSBLRpd1fMwIQnNNGRhsC1XjEirMVQ31OY=; b=K30UrZ30eFGQVLHxXnkFEuomk4ZZBZ6/86gsVWBDsV0EzGPrREwSurwdf3x7ZqrF2bJzjV srlmNK+0HBDjRghQ6As/LzWxqxgewgeHdhqFA0oe5hOvdQrDSo9h6ZHpswcQhVU4T5rcwj e8fqkf+gjE2qXw26OBxQaTIBhRunjJohu2SnDI8EhfJxyyjBlTpLvG7ymQWPVtGwr5oIsR /TlL0dI45YodVN5++g1d1zxtPTjTQWANlxYMaPSEutPTNOCryWR/JtQ8j7wWNv9EDpXU9o 7Qwp9gP2/fM+qGFlXOdCwfUUrsoJfENljEDa5LCUiQN64Mcf+NrVJtibGmIcCg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780947203; a=rsa-sha256; cv=none; b=Mh3T2wbLKPmzhZjWw8nIPrIgjHF/R2BbirWV0qtAGJ8ywt1ThnWnMdgwwd32yqWWH0s2GW sVDqU++LYA6oiG6B1RP4PNR7iTHmsOnrvXlzzkCb7YGZshZnQV3IdBefyD0PICTW+hbgR1 k7GM2g/MQdhF2JnjNvCnU3HcPBBFG+IaQ/9sfMClCB53PZtgy0cCl8vJ2mMcbquMj9EMGc nZmlc3DbkCZunDbCoOdx2kRfknbD4nowDVWa/fnsFVlIJCRvjcgW1BPlVNTKnkBLg5RU4A YQ0kihPRC9gG5JUllciKRK0EsZt3lrfOYmSAYhBxxoMIkRD4uO2PuO4quFwmyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780947203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G/cxXMtWWPSBLRpd1fMwIQnNNGRhsC1XjEirMVQ31OY=; b=NOHLWAmsJ2pP+9+22ckXy080oe1SU1+kr7r028LA38GQf9elI+DBheFF6QVCWbdVfC1xkV 4wdfQI6sLWQoyfAew1uiSBVIWsbLz6trPKDUsu08QgHN5Npo8t2YDJdMVObBnbxGFkFOhU 4ffDq5sJddL5DDTM5Ntg7UpCGpUiEkiKzLz5DL2F8Yf214xO6gl332VpBiFBYaw9pKGYiR Le7Q5gg0bBk+0AxzpZPUf0iHxucCcOOIc/vUvrjb/O5Mpumlxnm1qwYa/dG/DTfKbK53P9 UVQChJFi3Xs2pMQzZXh8ZYUmmN0vVJ6EO2yEYJd+btDJiLoN4ly6O/fgO5bDug== Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gZ2Jg3r0Sz19lb for ; Mon, 08 Jun 2026 19:33:23 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-39677114c7bso4162071fa.0 for ; Mon, 08 Jun 2026 12:33:23 -0700 (PDT) X-Forwarded-Encrypted: i=1; AFNElJ83QetQX3Pv9LwUc5UWh4G+srjFEHlcH9y4AItDUD93v4h1LkWvnJSCbPk89d/ll1ybPD/3/ffC5rM07n1LByE5p1kU@freebsd.org X-Gm-Message-State: AOJu0Ywu0xLfy26QERIR3EDqQ839px4aVfOyuMjNgNTw/k3jr7JTP5R4 pgNkLUEeRHewVWeKXzBN0dbpJ5wUchiAuxfT6e3ioxAKr6ex900uzaCI7+4+kbjlOargcLGXD5P q6zroUEyKsomY2CIqtoXtWqiSRKZhoJs= X-Received: by 2002:a05:651c:18cb:b0:38a:325a:8a0b with SMTP id 38308e7fff4ca-396d0a10734mr19879271fa.5.1780947202033; Mon, 08 Jun 2026 12:33:22 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a21bc18.2040e.38ce0e7e@gitrepo.freebsd.org> In-Reply-To: <6a21bc18.2040e.38ce0e7e@gitrepo.freebsd.org> From: Nuno Teixeira Date: Mon, 8 Jun 2026 20:33:10 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AVVi8Ce5xzbyZMryNCGXAhkVct0cEBnvUa0kZtd6h_UQrhADEPz-l-lk9hrAe6w Message-ID: Subject: Re: git: 453968c78d27 - main - uipc_usrreq: revert addition of EMPTYPATH for bindat(2) To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000574e000653c31544" --000000000000574e000653c31544 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Konstantin. I'm geting a testunit failure on devel/aws-c-io reported at https://github.com/awslabs/aws-c-io/issues/803 that might be related to this change. Any clues how to deal with it? Thanks, Konstantin Belousov escreveu (quinta, 4/06/2026 =C3=A0(s) 18:55): > The branch main has been updated by kib: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D453968c78d27ed5c90562a1178f34fe= 8d616bf40 > > commit 453968c78d27ed5c90562a1178f34fe8d616bf40 > Author: Konstantin Belousov > AuthorDate: 2026-06-04 17:26:09 +0000 > Commit: Konstantin Belousov > CommitDate: 2026-06-04 17:55:11 +0000 > > uipc_usrreq: revert addition of EMPTYPATH for bindat(2) > > The caller wants the parent vnode, which cannot be provided for > emptypath > lookups. > > Reported and reviewed by: markj > Fixes: 12c590a9abd7 ("bindat(2)/connectat(2): allow implicit > EMPTYPATH for unix domain sockets") > Sponsored by: The FreeBSD Foundation > MFC after: 1 week > Differential revision: https://reviews.freebsd.org/D57448 > --- > lib/libsys/open.2 | 4 +--- > sys/kern/uipc_usrreq.c | 5 ++--- > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/lib/libsys/open.2 b/lib/libsys/open.2 > index defc593b15ce..7915f7e8ef0a 100644 > --- a/lib/libsys/open.2 > +++ b/lib/libsys/open.2 > @@ -447,11 +447,9 @@ The other functionality of the returned file > descriptor is limited to > the following descriptor-level operations: > .Pp > .Bl -tag -width __acl_aclcheck_fd -offset indent -compact > -.It Xr bindat 2 > -for unix domain socket > -.Pq see Xr unix 4 > .It Xr connectat 2 > for unix domain socket > +.Pq see Xr unix 4 > .It Xr fcntl 2 > but advisory locking is not allowed > .It Xr dup 2 > diff --git a/sys/kern/uipc_usrreq.c b/sys/kern/uipc_usrreq.c > index a798aaf4f871..920588627914 100644 > --- a/sys/kern/uipc_usrreq.c > +++ b/sys/kern/uipc_usrreq.c > @@ -612,9 +612,8 @@ uipc_bindat(int fd, struct socket *so, struct sockadd= r > *nam, struct thread *td) > buf[namelen] =3D 0; > > restart: > - NDINIT_ATRIGHTS(&nd, CREATE, NOFOLLOW | LOCKPARENT | NOCACHE | > - EMPTYPATH, UIO_SYSSPACE, buf, fd, cap_rights_init_one(&rights= , > - CAP_BINDAT)); > + NDINIT_ATRIGHTS(&nd, CREATE, NOFOLLOW | LOCKPARENT | NOCACHE, > + UIO_SYSSPACE, buf, fd, cap_rights_init_one(&rights, > CAP_BINDAT)); > /* SHOULD BE ABLE TO ADOPT EXISTING AND wakeup() ALA FIFO's */ > error =3D namei(&nd); > if (error) > > --=20 Nuno Teixeira FreeBSD UNIX: Web: https://FreeBSD.org --000000000000574e000653c31544 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Konstantin.

I'm geti= ng a testunit failure on devel/aws-c-io reported at https://github.com/awslabs/aws-c-io/iss= ues/803 that might be related to this change.

Any clues ho= w to deal with it?

Thanks,

Konstantin Bel= ousov <kib@freebsd.org> escrev= eu (quinta, 4/06/2026 =C3=A0(s) 18:55):
The branch main has been updated by kib:

URL: https://cgit.= FreeBSD.org/src/commit/?id=3D453968c78d27ed5c90562a1178f34fe8d616bf40
commit 453968c78d27ed5c90562a1178f34fe8d616bf40
Author:=C2=A0 =C2=A0 =C2=A0Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2026-06-04 17:26:09 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2026-06-04 17:55:11 +0000

=C2=A0 =C2=A0 uipc_usrreq: revert addition of EMPTYPATH for bindat(2)

=C2=A0 =C2=A0 The caller wants the parent vnode, which cannot be provided f= or emptypath
=C2=A0 =C2=A0 lookups.

=C2=A0 =C2=A0 Reported and reviewed by:=C2=A0 =C2=A0 =C2=A0 =C2=A0markj
=C2=A0 =C2=A0 Fixes:=C2=A0 12c590a9abd7 ("bindat(2)/connectat(2): allo= w implicit EMPTYPATH for unix domain sockets")
=C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0The FreeBSD Foundation
=C2=A0 =C2=A0 MFC after:=C2=A0 =C2=A0 =C2=A0 1 week
=C2=A0 =C2=A0 Differential revision:=C2=A0 https://reviews.freebsd= .org/D57448
---
=C2=A0lib/libsys/open.2=C2=A0 =C2=A0 =C2=A0 | 4 +---
=C2=A0sys/kern/uipc_usrreq.c | 5 ++---
=C2=A02 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/lib/libsys/open.2 b/lib/libsys/open.2
index defc593b15ce..7915f7e8ef0a 100644
--- a/lib/libsys/open.2
+++ b/lib/libsys/open.2
@@ -447,11 +447,9 @@ The other functionality of the returned file descripto= r is limited to
=C2=A0the following descriptor-level operations:
=C2=A0.Pp
=C2=A0.Bl -tag -width __acl_aclcheck_fd -offset indent -compact
-.It Xr bindat 2
-for unix domain socket
-.Pq see Xr unix 4
=C2=A0.It Xr connectat 2
=C2=A0for unix domain socket
+.Pq see Xr unix 4
=C2=A0.It Xr fcntl 2
=C2=A0but advisory locking is not allowed
=C2=A0.It Xr dup 2
diff --git a/sys/kern/uipc_usrreq.c b/sys/kern/uipc_usrreq.c
index a798aaf4f871..920588627914 100644
--- a/sys/kern/uipc_usrreq.c
+++ b/sys/kern/uipc_usrreq.c
@@ -612,9 +612,8 @@ uipc_bindat(int fd, struct socket *so, struct sockaddr = *nam, struct thread *td)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 buf[namelen] =3D 0;

=C2=A0restart:
-=C2=A0 =C2=A0 =C2=A0 =C2=A0NDINIT_ATRIGHTS(&nd, CREATE, NOFOLLOW | LOC= KPARENT | NOCACHE |
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0EMPTYPATH, UIO_SYSSPACE, buf, fd,= cap_rights_init_one(&rights,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0CAP_BINDAT));
+=C2=A0 =C2=A0 =C2=A0 =C2=A0NDINIT_ATRIGHTS(&nd, CREATE, NOFOLLOW | LOC= KPARENT | NOCACHE,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0UIO_SYSSPACE, buf, fd, cap_rights= _init_one(&rights, CAP_BINDAT));
=C2=A0/* SHOULD BE ABLE TO ADOPT EXISTING AND wakeup() ALA FIFO's */ =C2=A0 =C2=A0 =C2=A0 =C2=A0 error =3D namei(&nd);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (error)



--
Nuno Teixeira
=
FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 https://Fr= eeBSD.org
--000000000000574e000653c31544--