Date: Thu, 21 Apr 2011 12:28:40 +0400 From: Pan Tsu <inyaoo@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/156543: [patch] Mk/bsd.cmake.mk: distinguish STRIP from WITH_DEBUG Message-ID: <86bp00ovnr.fsf@gmail.com> Resent-Message-ID: <201104210830.p3L8UCcW069311@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 156543
>Category: ports
>Synopsis: [patch] Mk/bsd.cmake.mk: distinguish STRIP from WITH_DEBUG
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Apr 21 08:30:12 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Pan Tsu
>Release: FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
Respect STRIP for USE_CMAKE ports like INSTALL_MACROS do.
- some VMs embed data in way that stripping makes produced executable broken
- some bugs can only be reproduced with optimization enabled
- compile-time debugging may be useful without symbols, e.g. asserts
>How-To-Repeat:
>Fix:
--- a.diff begins here ---
Index: Mk/bsd.cmake.mk
===================================================================
RCS file: /a/.cvsup/ports/Mk/bsd.cmake.mk,v
retrieving revision 1.9
diff -u -p -r1.9 bsd.cmake.mk
--- Mk/bsd.cmake.mk 10 Apr 2011 08:40:13 -0000 1.9
+++ Mk/bsd.cmake.mk 21 Apr 2011 07:31:44 -0000
@@ -73,6 +73,9 @@ CMAKE_INSTALL_PREFIX?= ${PREFIX}
CMAKE_BUILD_TYPE?= Debug
.else
CMAKE_BUILD_TYPE?= Release
+.endif
+
+.if defined(STRIP) && ${STRIP} != ""
INSTALL_TARGET?= install/strip
.endif
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86bp00ovnr.fsf>