Date: Tue, 27 Apr 2021 23:25:21 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Neel Chauhan <neel@neelc.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Subject: Re: An apology about my commits Message-ID: <d8982994-d016-ba9d-f884-70675f569335@selasky.org> In-Reply-To: <6ae37bda99dfc279faff0ed0d50e3bfe@neelc.org> References: <6ae37bda99dfc279faff0ed0d50e3bfe@neelc.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/27/21 12:53 AM, Neel Chauhan wrote: > Hi src committers, > > I hope all is well with you. > > I am really sorry about me prematurely pushing these MFC'ing these > linuxkpi commits to stable/13 instead of waiting out the three-day minimum: > > > Going forward, I will respect the 3 day waiting period for future src > commits. > > I hope you all have a great day. Hi Neel, All your patches were solid and reviewed by others and didn't break the builds. I would expect that the comments in differential were squashed together as a single patch before the commit. I personally use "env GIT_EDITOR=ee git rebase -i", and then change the word "pick" into "s" for squashing. The 3-day minimum waiting period is more or less to catch issues with the patches before they hit -stable branches. Only in rare cases I've seen exceptions, but I've never seen anyone loose their commit bits over that :-) So don't worry and sleep well. Keep up the good work in the LinuxKPI Neel! And if in doubt there are many active FreeBSD developers to ask before commit :-) --HPS > > Thank You, > > Neel Chauhan (nc@) > _______________________________________________ > dev-commits-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all > To unsubscribe, send any mail to > "dev-commits-src-all-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d8982994-d016-ba9d-f884-70675f569335>