From nobody Mon Jan 26 00:52:31 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dzqkm04Hwz6PMgp for ; Mon, 26 Jan 2026 00:52:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dzqkl5RCwz3Rqt for ; Mon, 26 Jan 2026 00:52:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769388751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=b3+KQG9Z6Q0v8mYWCwFmxKURqt6AaEjZ4JzLtJuRgIo=; b=pGMXkliXAUVsv93MZsFiXu6yZ1615Xrp5GbEkfiyNGmqDubY3tIM5sTlX7CJvWvfOVepwI GkFdXc+uzCh+NAI6NW2SxDrZDUwpR00hjOiqxzJar33laM1HeZcpuRQcnX1/WqWMtoZWrY GoegUc/JiZyacBhzsZg58wy2Fx+3PV3hB5Kn59ctXrqd7vqbKKXSplmOwrQj/dHwjgm08W gVxjHL9QkQ/1nbSmK+lIsWJDuUjSuHmS6XwNdwCNP4KKLqQKiNVPXO6ahMetN2SKGI40UO Qz+ZOIwsaAmtZRGsJISDVQEBjycYqqP8yycDKBIZmQXg9cw6Hxw8RxOE6Ra+DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769388751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=b3+KQG9Z6Q0v8mYWCwFmxKURqt6AaEjZ4JzLtJuRgIo=; b=PoyrjEA7JJz/EPx58zdT1f/bPqgSbtrbX7H2wP2PGGY5dchp0lpzMRzzW1S76Za7FIfXCq gq+GCQ04+2/uO4K85bQVMfIMM74CD17sREFBjuIC52DVKyrU1++zjOiVQvJRlH4bW3Qh7a 6XayNRsQVPKoQiQfZTtbyu6IwcS1tfD071K2Hu4YFJuWC+KcbQP1EhcnZk3hY7t+IfUIXL 18irqjjkHQb2RJXGAiNUaaYo8u/RvJCl1rRf5NglQkWmcY6LfePXKT28aAkxJ0Q+gr8U7n 7kH7dS+BP0sm0uS3t+60iQ6h/BuunvEEDpfDm4RwjlI0Zh2RRb5jCEXoJl7Bzw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769388751; a=rsa-sha256; cv=none; b=KzGdu2o1Q73g/x1XFNbxKN2sFcpCPW8LDOimMzrfxgksug8o/Q2FeGyhDWQSiUQK4uiKRI uR5Sgw6o00jkH2ziLOXsCR4JljhfETEnvaOkne7eAr+8rzuAmFQTg75QGV8qJOzBHy5VMX M4LT6XR0WRK0ywibroRSrgr9fKsrtc2ZlpFYAoCaRXAvLBGLxf4TxqWnyRxQIoyAjX2rkD EA27Cok6AEYgWgyWIRCdCW3QIiclJhrfFpVTtkTbeSCX5irUaLKkiE/xO4nSGuW6Hw8IyI Rw2ABo0BKIGf8zV1whDK+7MuwEvliy9E7ZchhjidTeJZrzp3wZ2s8Y5dVXAqyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dzqkl51WrzyfK for ; Mon, 26 Jan 2026 00:52:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 47ec0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 26 Jan 2026 00:52:31 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Abdelkader Boudih From: Mark Johnston Subject: git: da714e3e8537 - stable/15 - isl: Convert driver to CTLFLAG_MPSAFE List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: da714e3e853742ad5d6adb84c97fc52d8c8707ff Auto-Submitted: auto-generated Date: Mon, 26 Jan 2026 00:52:31 +0000 Message-Id: <6976bacf.47ec0.4250d0a2@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=da714e3e853742ad5d6adb84c97fc52d8c8707ff commit da714e3e853742ad5d6adb84c97fc52d8c8707ff Author: Abdelkader Boudih AuthorDate: 2026-01-12 00:51:57 +0000 Commit: Mark Johnston CommitDate: 2026-01-26 00:51:44 +0000 isl: Convert driver to CTLFLAG_MPSAFE Replace CTLFLAG_NEEDGIANT with CTLFLAG_MPSAFE for all light sensor sysctls. All of the sysctl handlers are serialized by a driver mutex. Sysctls converted: - dev.isl.X.als (ambient light sensor) - dev.isl.X.ir (infrared sensor) - dev.isl.X.prox (proximity sensor) - dev.isl.X.resolution (sensor resolution) - dev.isl.X.range (sensor range) Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54621 (cherry picked from commit 0672e0e38a08c580f723a02bb183344d8c7cee65) --- sys/dev/isl/isl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/dev/isl/isl.c b/sys/dev/isl/isl.c index 6a0d406aeeda..815c189adee5 100644 --- a/sys/dev/isl/isl.c +++ b/sys/dev/isl/isl.c @@ -202,7 +202,7 @@ isl_attach(device_t dev) if (use_als) { SYSCTL_ADD_PROC(sysctl_ctx, SYSCTL_CHILDREN(sysctl_tree), OID_AUTO, "als", - CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_MPSAFE, sc, ISL_METHOD_ALS, isl_sysctl, "I", "Current ALS sensor read-out"); } @@ -210,7 +210,7 @@ isl_attach(device_t dev) if (use_ir) { SYSCTL_ADD_PROC(sysctl_ctx, SYSCTL_CHILDREN(sysctl_tree), OID_AUTO, "ir", - CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_MPSAFE, sc, ISL_METHOD_IR, isl_sysctl, "I", "Current IR sensor read-out"); } @@ -218,20 +218,20 @@ isl_attach(device_t dev) if (use_prox) { SYSCTL_ADD_PROC(sysctl_ctx, SYSCTL_CHILDREN(sysctl_tree), OID_AUTO, "prox", - CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_MPSAFE, sc, ISL_METHOD_PROX, isl_sysctl, "I", "Current proximity sensor read-out"); } SYSCTL_ADD_PROC(sysctl_ctx, SYSCTL_CHILDREN(sysctl_tree), OID_AUTO, "resolution", - CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_MPSAFE, sc, ISL_METHOD_RESOLUTION, isl_sysctl, "I", "Current proximity sensor resolution"); SYSCTL_ADD_PROC(sysctl_ctx, SYSCTL_CHILDREN(sysctl_tree), OID_AUTO, "range", - CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_NEEDGIANT, sc, + CTLTYPE_INT | CTLFLAG_RD | CTLFLAG_MPSAFE, sc, ISL_METHOD_RANGE, isl_sysctl, "I", "Current proximity sensor range");