From owner-svn-src-head@FreeBSD.ORG Fri Mar 27 06:32:53 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C8BE1065670; Fri, 27 Mar 2009 06:32:53 +0000 (UTC) (envelope-from vd@v5d.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EAC798FC1A; Fri, 27 Mar 2009 06:32:52 +0000 (UTC) (envelope-from vd@v5d.org) Received: from mail.v5d.org (root@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n2R6WpGq050221; Fri, 27 Mar 2009 06:32:52 GMT (envelope-from vd@v5d.org) Received: by mail.v5d.org (Postfix, from userid 1002) id 60B6540F8; Fri, 27 Mar 2009 08:32:51 +0200 (EET) Date: Fri, 27 Mar 2009 08:32:51 +0200 From: Vasil Dimov To: Coleman Kane Message-ID: <20090327063251.GA95057@polejan.hw.v5d.org> References: <200903142010.n2EKAESF006945@svn.freebsd.org> <20090320140015.GA17645@hub.freebsd.org> <20090320153405.GA62675@zim.MIT.EDU> <49C3BCD4.4030605@freebsd.org> <1237567495.1993.2.camel@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline In-Reply-To: <1237567495.1993.2.camel@localhost> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Sam Leffler , src-committers@FreeBSD.org Subject: Re: svn commit: r189828 - in head: include sys/sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: vd@FreeBSD.org List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2009 06:32:53 -0000 --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 20, 2009 at 12:44:55 -0400, Coleman Kane wrote: [...] > > > On Fri, Mar 20, 2009, Vasil Dimov wrote: > > > =20 > > >> On Sat, Mar 14, 2009 at 08:10:14PM +0000, David Schultz wrote: > > >> =20 > > >>> Author: das > > >>> Date: Sat Mar 14 20:10:14 2009 > > >>> New Revision: 189828 > > >>> URL: http://svn.freebsd.org/changeset/base/189828 > > >>> > > >>> Log: > > >>> Fix the visibility of several prototypes. Also move pthread_kill(= ) and > > >>> pthread_sigmask() to signal.h. In principle, this shouldn't break= anything, > > >>> =20 > > >> [...] > > >> > > >> But it did break, see http://www.freebsd.org/cgi/query-pr.cgi?pr=3D1= 32828 [...] > I was able to solve the problem by removing the "#include " > from the offending file (there is only one) in devel/pth. After that, it > built fine and I am using it now. [...] Hi, I do not have access to 8-current machine so I have some dump questions: 1. From which file did you remove "#include "? I am afraid that if we remove it from pth_p.h.in then this problem could arise again after the user has installed pth and is trying to use it and has included signal.h for some other reason in his source. I.e. if pth's pthread.h and the system's signal.h are included in one source file this problem will resurface. 2. Hmm, why are the prototypes conflicting in the first place? extern int pthread_kill(pthread_t, int); int pthread_kill(__pthread_t, int); 3. /usr/include/signal.h defines pthread_kill() only if __POSIX_VISIBLE or __XSI_VISIBLE is defined. Can someone try to inject #undef __POSIX_VISIBLE or #undef __XSI_VISIBLE into pth's pthread.h.in to see if this fixes the problem and does not cause other problems? Thank you! --=20 Vasil Dimov --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAknMcxMACgkQFw6SP/bBpCB5rgCgxW3jDMDFt+4XJPosvM1fHXSW 814An1oLJkV8yrbJdy/DufnyCuBLqyxe =furC -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N--