From owner-cvs-src@FreeBSD.ORG Fri Aug 1 11:44:58 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5FABA37B401; Fri, 1 Aug 2003 11:44:58 -0700 (PDT) Received: from smtp2.server.rpi.edu (smtp2.server.rpi.edu [128.113.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55AD843FCB; Fri, 1 Aug 2003 11:44:57 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp2.server.rpi.edu (8.12.9/8.12.9) with ESMTP id h71IitCx018170; Fri, 1 Aug 2003 14:44:55 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20030802000356.P1436@gamplex.bde.org> References: <200308010904.h7194W4a061763@repoman.freebsd.org> <20030802000356.P1436@gamplex.bde.org> Date: Fri, 1 Aug 2003 14:44:54 -0400 To: Bruce Evans , Gordon Tetlow From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/rescue/rescue Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2003 18:44:58 -0000 At 12:11 AM +1000 8/2/03, Bruce Evans wrote: >On Fri, 1 Aug 2003, Gordon Tetlow wrote: > >> gordon 2003/08/01 02:04:32 PDT >> >> FreeBSD src repository >> >> Modified files: >> rescue/rescue Makefile >> Log: > > When using crunchgen, blow away MAKEFLAGS. This fixes > > make -j <#> -P from passing the -P flag to crunchgen > > which seems to confuse crunchgen horribly. > >Doesn't also prevent make -j <#> -P from passing the -j <#> >flag and any other useful flags that may be in MAKEFLAGS? Yes, but chances are that '-j' isn't going to make much of a significant difference when crunchgen is building it's makefiles. I'm not even sure that it is safe for '-j' (I actually have no idea whether it is safe or not). > > This is the preferable solution to modifing crunchgen to >> unset the MAKEFLAGS environment variable. > >Certainly, since unsetting MAKEFLAGS very generally would be >more likely to lose something important in it. > >Setting MAKEFLAGS to ${MAKEFLAGS:N-P} might be safe enough >to do generally. crunchgen also fails if you specify any debugging flags on the original 'make' command, so the problem is much more than just -P. By making this change in the rescue Makefile, we'll quickly sidestep a number of surprise headaches for someone trying to do buildworlds. But at the same time, if someone really wants crunchgen to run *it's* 'make' with some flags set, they will have an easy way to do that. Also, this change only effects building src/rescue, and not does not effect any other users of crunchgen. A better fix would be to make crunchgen a lot smarter about the output (from make) that it is parsing, but that will also take longer to write up. I do hope to look into that, but probably not right away. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu