Date: Mon, 26 Aug 2024 19:14:48 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 280913] [patch] Unexpected state of vnet-jails with ifconfig_DEFAULT="DHCP" in rc.conf(5) Message-ID: <bug-280913-227-FaxjcBvDda@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-280913-227@https.bugs.freebsd.org/bugzilla/> References: <bug-280913-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280913 --- Comment #4 from Harald Schmalzbauer <bugzilla.freebsd@omnilan.de> --- (In reply to crest from comment #3) Good point. But this patch for syncdhcpif() of /etc/network.subr is not re= ally affected, since $1 in syncdhcpif() was passed unquoted from ifconfig_up() w= hich in turn got it from ifn_start() as unquoted parameter ${ifn}. get_if_var() uses ltr() to normalize IF. From a quick look, only IFNAME consisting of the four ".-/+" punctuation characters are valid, which are unconditionally replaced by the underscore character. rc(8) would break far earlier if somebody manually renamed the interface to anything allowed by t= he core struct (if not prevented by ifconfig(8)) and tries to non-maually atta= ch dhclient to it. For consistency reasons I'd prefer to keep it unquoted since I see no possibility that $1 can ever be anything else than shell variable characters (get_if_var() would fail to return any of the DHCP pseudo-args, so syncdhcp= if() wouldn't be called). The wrong whitespace indention bothers me more ;-) Thanks for looking at it! --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-280913-227-FaxjcBvDda>