From owner-cvs-src@FreeBSD.ORG Fri Sep 8 17:22:42 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 597FD16A4E1; Fri, 8 Sep 2006 17:22:42 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from fw.zoral.com.ua (fw.zoral.com.ua [213.186.206.134]) by mx1.FreeBSD.org (Postfix) with ESMTP id 96FE243D6E; Fri, 8 Sep 2006 17:22:38 +0000 (GMT) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by fw.zoral.com.ua (8.13.4/8.13.4) with ESMTP id k88HMSKJ054036 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 8 Sep 2006 20:22:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.13.8/8.13.8) with ESMTP id k88HMXq6058758; Fri, 8 Sep 2006 20:22:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.13.8/8.13.8/Submit) id k88HMWU8058757; Fri, 8 Sep 2006 20:22:32 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 8 Sep 2006 20:22:32 +0300 From: Kostik Belousov To: Jung-uk Kim Message-ID: <20060908172232.GG14781@deviant.kiev.zoral.com.ua> References: <200609081459.k88ExtSR084500@repoman.freebsd.org> <200609081309.29850.jkim@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="64j1qyTOoGvYcHb1" Content-Disposition: inline In-Reply-To: <200609081309.29850.jkim@FreeBSD.org> User-Agent: Mutt/1.4.2.2i X-Virus-Scanned: ClamAV version 0.88.4, clamav-milter version 0.88.4 on fw.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=1.9 required=5.0 tests=DNS_FROM_RFC_ABUSE, SPF_NEUTRAL,UNPARSEABLE_RELAY autolearn=no version=3.1.4 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.1.4 (2006-07-25) on fw.zoral.com.ua Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/libexec/rtld-elf rtld.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2006 17:22:42 -0000 --64j1qyTOoGvYcHb1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 08, 2006 at 01:09:24PM -0400, Jung-uk Kim wrote: > On Friday 08 September 2006 10:59 am, Konstantin Belousov wrote: > > kib 2006-09-08 14:59:55 UTC > > > > FreeBSD src repository > > > > Modified files: > > libexec/rtld-elf rtld.c > > Log: > > When looking up the symbol by dlsym, look it not only in the > > object given as dso handle, but also in the implicit dependencies > > of that dso. > > > > Also, const-ify the read-only parameter objlist of symlook_list. > > > > Reported by: "Simon 'corecode' Schubert" > tum de> Approved by: kan (mentor) > > X-MFC-After: 6.2 > > > > Revision Changes Path > > 1.117 +10 -13 src/libexec/rtld-elf/rtld.c >=20 > I believe this warrants version number change for ports, IMO. This change brings rtld behaviour to the standard. Solaris and Linux both do this in the right way. Shall we bump __FreeBSD_version for such kind of bugfixes ? BTW, are you aware of ports that rely on old behaviour ? --64j1qyTOoGvYcHb1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFAabXC3+MBN1Mb4gRArvJAJ9LF+DTGdp3D1MyYnRUR0/f1Bri1ACgxnvv Q2BThmqGsIKFV3HiAK8LT/M= =/eKd -----END PGP SIGNATURE----- --64j1qyTOoGvYcHb1--