From owner-svn-src-head@freebsd.org Wed Sep 4 14:21:57 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0F2BBF31E8; Wed, 4 Sep 2019 14:21:57 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46NmGr6GSCz4McC; Wed, 4 Sep 2019 14:21:56 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (Seawolf.HML3.ScaleEngine.net [209.51.186.28]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id B329223DC1; Wed, 4 Sep 2019 14:21:55 +0000 (UTC) Subject: Re: svn commit: r351812 - head/usr.sbin/mpsutil To: Alan Somers , Andriy Gapon Cc: src-committers , svn-src-all , svn-src-head References: <201909041347.x84Dlcds017291@repo.freebsd.org> From: Allan Jude Openpgp: preference=signencrypt Autocrypt: addr=allanjude@freebsd.org; prefer-encrypt=mutual; keydata= mQINBFVwZcYBEADwrZDH0xe0ZVjc9ORCc6PcBLwS/RTXA6NkvpD6ea02pZ8lPOVgteuuugFc D34LdDbiWr+479vfrKBh+Y38GL0oZ0/13j10tIlDMHSa5BU0y6ACtnhupFvVlQ57+XaJAb/q 7qkfSiuxVwQ3FY3PL3cl1RrIP5eGHLA9hu4eVbu+FOX/q/XVKz49HaeIaxzo2Q54572VzIo6 C28McX9m65UL5fXMUGJDDLCItLmehZlHsQQ+uBxvODLFpVV2lUgDR/0rDa0B9zHZX8jY8qQ7 ZdCSy7CwClXI054CkXZCaBzgxYh/CotdI8ezmaw7NLs5vWNTxaDEFXaFMQtMVhvqQBpHkfOD 7rjjOmFw00nJL4FuPE5Yut0CPyx8vLjVmNJSt/Y8WxxmhutsqJYFgYfWl/vaWkrFLur/Zcmz IklwLw35HLsCZytCN5A3rGKdRbQjD6QPXOTJu0JPrJF6t2xFkWAT7oxnSV0ELhl2g+JfMMz2 Z1PDmS3NRnyEdqEm7NoRGXJJ7bgxDbN+9SXTyOletqGNXj/bSrBvhvZ0RQrzdHAPwQUfVSU2 qBhQEi2apSZstgVNMan0GUPqCdbE2zpysg+zT7Yhvf9EUQbzPL4LpdK1llT9fZbrdMzEXvEF oSvwJFdV3sqKmZc7b+E3PuxK6GTsKqaukd/3Cj8aLHG1T1im1QARAQABtCJBbGxhbiBKdWRl IDxhbGxhbmp1ZGVAZnJlZWJzZC5vcmc+iQI/BBMBAgApBQJVcGXGAhsjBQkSzAMABwsJCAcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQGZU1PhKYC34Muw/+JOKpSfhhysWFYiRXynGRDe07 Z6pVsn7DzrPUMRNZfHu8Uujmmy3p2nx9FelIY9yjd2UKHhug+whM54MiIFs90eCRVa4XEsPR 4FFAm0DAWrrb7qhZFcE/GhHdRWpZ341WAElWf6Puj2devtRjfYbikvj5+1V1QmDbju7cEw5D mEET44pTuD2VMRJpu2yZZzkM0i+wKFuPxlhqreufA1VNkZXI/rIfkYWK+nkXd9Efw3YdCyCQ zUgTUCb88ttSqcyhik/li1CDbXBpkzDCKI6I/8fAb7jjOC9LAtrZJrdgONywcVFoyK9ZN7EN AVA+xvYCmuYhR/3zHWH1g4hAm1v1+gIsufhajhfo8/wY1SetlzPaYkSkVQLqD8T6zZyhf+AN bC7ci44UsiKGAplB3phAXrtSPUEqM86kbnHg3fSx37kWKUiYNOnx4AC2VXvEiKsOBlpyt3dw WQbOtOYM+vkfbBwDtoGOOPYAKxc4LOIt9r+J8aD+gTooi9Eo5tvphATf9WkCpl9+aaGbSixB tUpvQMRnSMqTqq4Z7DeiG6VMRQIjsXDSLJEUqcfhnLFo0Ko/RiaHd5xyAQ4DhQ9QpkyQjjNf /3f/dYG7JAtoD30txaQ5V8uHrz210/77DRRX+HJjEj6xCxWUGvQgvEZf5XXyxeePvqZ+zQyT DX61bYw6w6a5Ag0EVXBlxgEQAMy7YVnCCLN4oAOBVLZ5nUbVPvpUhsdA94/0/P+uqCIh28Cz ar56OCX0X19N/nAWecxL4H32zFbIRyDB2V/MEh4p9Qvyu/j4i1r3Ex5GhOT2hnit43Ng46z5 29Es4TijrHJP4/l/rB2VOqMKBS7Cq8zk1cWqaI9XZ59imxDNjtLLPPM+zQ1yE3OAMb475QwN UgWxTMw8rkA7CEaqeIn4sqpTSD5C7kT1Bh26+rbgJDZ77D6Uv1LaCZZOaW52okW3bFbdozV8 yM2u+xz2Qs8bHz67p+s+BlygryiOyYytpkiK6Iy4N7FTolyj5EIwCuqzfk0SaRHeOKX2ZRjC qatkgoD/t13PNT38V9tw3qZVOJDS0W6WM8VSg+F+bkM9LgJ8CmKV+Hj0k3pfGfYPOZJ/v18i +SmZmL/Uw2RghnwDWGAsPCKu4uZR777iw7n9Io6Vfxndw2dcS0e9klvFYoaGS6H2F13Asygr WBzFNGFQscN4mUW+ZYBzpTOcHkdT7w8WS55BmXYLna+dYer9/HaAuUrONjujukN4SPS1fMJ2 /CS/idAUKyyVVX5vozoNK2JVC1h1zUAVsdnmhEzNPsvBoqcVNfyqBFROEVLIPwq+lQMGNVjH ekLTKRWf59MEhUC2ztjSKkGmwdg73d6xSXMuq45EgIJV2wPvOgWQonoHH/kxABEBAAGJAiUE GAECAA8FAlVwZcYCGwwFCRLMAwAACgkQGZU1PhKYC34w5A//YViBtZyDV5O+SJT9FFO3lb9x Zdxf0trA3ooCt7gdBkdnBM6T5EmjgVZ3KYYyFfwXZVkteuCCycMF/zVw5eE9FL1+zz9gg663 nY9q2F77TZTKXVWOLlOV2bY+xaK94U4ytogOGhh9b4UnQ/Ct3+6aviCF78Go608BXbmF/GVT 7uhddemk7ItxM1gE5Hscx3saxGKlayaOsdPKeGTVJCDEtHDuOc7/+jGh5Zxpk/Hpi+DUt1ot 8e6hPYLIQa4uVx4f1xxxV858PQ7QysSLr9pTV7FAQ18JclCaMc7JWIa3homZQL/MNKOfST0S 2e+msuRwQo7AnnfFKBUtb02KwpA4GhWryhkjUh/kbVc1wmGxaU3DgXYQ5GV5+Zf4kk/wqr/7 KG0dkTz6NLCVLyDlmAzuFhf66DJ3zzz4yIo3pbDYi3HB/BwJXVSKB3Ko0oUo+6/qMrOIS02L s++QE/z7K12CCcs7WwOjfCYHK7VtE0Sr/PfybBdTbuDncOuAyAIeIKxdI2nmQHzl035hhvQX s4CSghsP319jAOQiIolCeSbTMD4QWMK8RL/Pe1FI1jC3Nw9s+jq8Dudtbcj2UwAP/STUEbJ9 5rznzuuhPjE0e++EU/RpWmcaIMK/z1zZDMN+ce2v1qzgV936ZhJ3iaVzyqbEE81gDxg3P+IM kiYh4ZtPB4Q= Message-ID: <8edfc58e-21c8-3233-2167-2d83af6c3a5f@freebsd.org> Date: Wed, 4 Sep 2019 10:21:40 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LVnwDkWpTwFvnwtr6dBIwo0djSDNF9BAQ" X-Rspamd-Queue-Id: 46NmGr6GSCz4McC X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.89 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.986,0]; NEURAL_HAM_SHORT(-0.90)[-0.902,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2019 14:21:57 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LVnwDkWpTwFvnwtr6dBIwo0djSDNF9BAQ Content-Type: multipart/mixed; boundary="1mnSuyVn6QnUTBxuNJCg0gWkCYyMwajep"; protected-headers="v1" From: Allan Jude To: Alan Somers , Andriy Gapon Cc: src-committers , svn-src-all , svn-src-head Message-ID: <8edfc58e-21c8-3233-2167-2d83af6c3a5f@freebsd.org> Subject: Re: svn commit: r351812 - head/usr.sbin/mpsutil References: <201909041347.x84Dlcds017291@repo.freebsd.org> In-Reply-To: --1mnSuyVn6QnUTBxuNJCg0gWkCYyMwajep Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2019-09-04 09:50, Alan Somers wrote: > On Wed, Sep 4, 2019 at 7:47 AM Andriy Gapon > wrote: >=20 > Author: avg > Date: Wed Sep=C2=A0 4 13:47:38 2019 > New Revision: 351812 > URL: https://svnweb.freebsd.org/changeset/base/351812 >=20 > Log: > =C2=A0 mpsutil slot set status >=20 > =C2=A0 This code has been written as a proof of concept, but I thin= k that it > =C2=A0 can be useful in general.=C2=A0 It allows to set the status = of an enclosure > =C2=A0 slot.=C2=A0 Practically, this means controlling whatever slo= t status > LEDs the > =C2=A0 enclosure provides.=C2=A0 At present, the new command does n= ot have sanity > =C2=A0 checks or any conveniences.=C2=A0 That means that it is poss= ible to > issue the > =C2=A0 command for an invalid slot and an enclosure.=C2=A0 But the = worst I > have seen > =C2=A0 happening is either the command failing or simply being igno= red.=C2=A0 > Also, > =C2=A0 at the moment, the status has to be specified as a numeric b= it mask. > =C2=A0 The bit definitions can be found in sys/dev/mps/mpi/mpi2_ini= t.h, they > =C2=A0 are prefixed with MPI2_SEP_REQ_SLOTSTATUS_.=C2=A0 The only w= ay to address a > =C2=A0 slot is by the enclosure handle and the slot number.=C2=A0 B= oth are readily > =C2=A0 available from mpsutil show commands. >=20 > =C2=A0 So, future enhancements could include alternative ways to ad= dress > a slot > =C2=A0 (e.g., by a disk handle or a disk device name) and human fri= endly > names > =C2=A0 for slot statuses. >=20 > =C2=A0 The new command is useful alternative to 'sas2ircu locate' c= ommand. > =C2=A0 First, sas2ircu is a proprietary blob.=C2=A0 Second, it supp= orts > setting only > =C2=A0 locate / identify status bit. >=20 > =C2=A0 Tested on HP H220 running LSI IT firmware 20.x. >=20 > =C2=A0 Reviewed by:=C2=A0 bapt > =C2=A0 MFC after:=C2=A0 =C2=A0 3 weeks > =C2=A0 Differential Revision:=C2=A0 =C2=A0 =C2=A0 =C2=A0 https://re= views.freebsd.org/D20535 >=20 > Added: > =C2=A0 head/usr.sbin/mpsutil/mps_slot.c=C2=A0 =C2=A0(contents, prop= s changed) > Modified: > =C2=A0 head/usr.sbin/mpsutil/Makefile > =C2=A0 head/usr.sbin/mpsutil/mps_cmd.c > =C2=A0 head/usr.sbin/mpsutil/mpsutil.h >=20 >=20 > Is this redundant with sesutil, or does it work on different kinds of > enclosures?=C2=A0 mpsutil's method will work on direct-attach backplanes and enclosures, where sesutil only works if there is an expander that provides the SES service. --=20 Allan Jude --1mnSuyVn6QnUTBxuNJCg0gWkCYyMwajep-- --LVnwDkWpTwFvnwtr6dBIwo0djSDNF9BAQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJdb8iCAAoJEBmVNT4SmAt+deIQAIvrNYEBZIUiq+w00kFaZTKC ggQz7+xpNHXms09TBtDqv+1knD1RjW/2PL4VsE1yeL1QGYtkY9ruqWeZrp8Jpn40 bW3AiVjC6A7JSo/ApTODue7h7UEqy/SvOYlvxObCHULIwhfMpMKLVavFKnrI3jrN b4IonjYmHqFoVvWeHKPHoySwbGXuf29lJYB2iNmuoFqg5lXiqEVfzH5wHPCSx5f9 CAoy2Q+PfyE6WN8F1vnmPcnBXK6bULlygpjC3pKLyPQNZk22hHQScBzb3gaeOhdn Ti/k6Tbh5XJrcOZNHWa+xUeaD7ejHxuLNS9Bm4DKa71oi+itUvJXpqUNbQHBepeQ pQ66U2wwD1hzBUuluvAwAOtOzyAPtKRhO4Z8IXtCyfIhah2GG7uv+7RHnBqmNLBE CFL2CD3xEU0QqHJGlfW5P+zGz7Yc3WLNxM9NIGPDv05r41iVU4z5BdQQUGcGyOeL Aol2ru75MXwzg4IG9Jws5NCxdHkA1udoVBysftirpOQ50NHiMP5Z0/eyHtzK3d7Y NZ8ximmT166oty2Hb01vz/UODoYCSdpeADn6ZWgVkCdaE3euWstRP4VbLkUX1L6C LdbvOzLmtF9vFe+GotrYiFFIRVBXOJWWbPq2MgzE9smgtZS2bZc/5empVyCzIO58 9s5mXlt994UOynRqwOAd =lDiF -----END PGP SIGNATURE----- --LVnwDkWpTwFvnwtr6dBIwo0djSDNF9BAQ--