From owner-p4-projects@FreeBSD.ORG  Tue May 29 18:59:07 2012
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7E78E1065677; Tue, 29 May 2012 18:59:07 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 40CD51065673
	for <perforce@freebsd.org>; Tue, 29 May 2012 18:59:07 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
	[IPv6:2001:4f8:fff6::2d])
	by mx1.freebsd.org (Postfix) with ESMTP id 295DC8FC0A
	for <perforce@freebsd.org>; Tue, 29 May 2012 18:59:07 +0000 (UTC)
Received: from skunkworks.freebsd.org (localhost [127.0.0.1])
	by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id q4TIx7w1021593
	for <perforce@freebsd.org>; Tue, 29 May 2012 18:59:07 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id q4TIx6DL021590
	for perforce@freebsd.org; Tue, 29 May 2012 18:59:06 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Tue, 29 May 2012 18:59:06 GMT
Message-Id: <201205291859.q4TIx6DL021590@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 211946 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 May 2012 18:59:07 -0000

http://p4web.freebsd.org/@@211946?ac=10

Change 211946 by rwatson@rwatson_svr_ctsrd_mipsbuild on 2012/05/29 18:58:21

	When printing page fault information for an unexpected exception
	type, explicitly print out "unknown" rather than an empty string,
	and include the exception type number for ease of debugging.

Affected files ...

.. //depot/projects/ctsrd/beribsd/src/sys/mips/mips/trap.c#3 edit

Differences ...

==== //depot/projects/ctsrd/beribsd/src/sys/mips/mips/trap.c#3 (text+ko) ====

@@ -1377,15 +1377,17 @@
 		read_or_write = "read";
 		break;
 	default:
-		read_or_write = "";
+		read_or_write = "unknown";
 	}
 
 	pc = frame->pc + (DELAYBRANCH(frame->cause) ? 4 : 0);
-	log(LOG_ERR, "%s: pid %d (%s), uid %d: pc %#jx got a %s fault at %#jx\n",
+	log(LOG_ERR, "%s: pid %d (%s), uid %d: pc %#jx got a %s fault "
+	    "(type %#x) at %#jx\n",
 	    msg, p->p_pid, p->p_comm,
 	    p->p_ucred ? p->p_ucred->cr_uid : -1,
 	    (intmax_t)pc,
 	    read_or_write,
+	    trap_type,
 	    (intmax_t)frame->badvaddr);
 
 	/* log registers in trap frame */