Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 May 2012 18:59:06 GMT
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 211946 for review
Message-ID:  <201205291859.q4TIx6DL021590@skunkworks.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@211946?ac=10

Change 211946 by rwatson@rwatson_svr_ctsrd_mipsbuild on 2012/05/29 18:58:21

	When printing page fault information for an unexpected exception
	type, explicitly print out "unknown" rather than an empty string,
	and include the exception type number for ease of debugging.

Affected files ...

.. //depot/projects/ctsrd/beribsd/src/sys/mips/mips/trap.c#3 edit

Differences ...

==== //depot/projects/ctsrd/beribsd/src/sys/mips/mips/trap.c#3 (text+ko) ====

@@ -1377,15 +1377,17 @@
 		read_or_write = "read";
 		break;
 	default:
-		read_or_write = "";
+		read_or_write = "unknown";
 	}
 
 	pc = frame->pc + (DELAYBRANCH(frame->cause) ? 4 : 0);
-	log(LOG_ERR, "%s: pid %d (%s), uid %d: pc %#jx got a %s fault at %#jx\n",
+	log(LOG_ERR, "%s: pid %d (%s), uid %d: pc %#jx got a %s fault "
+	    "(type %#x) at %#jx\n",
 	    msg, p->p_pid, p->p_comm,
 	    p->p_ucred ? p->p_ucred->cr_uid : -1,
 	    (intmax_t)pc,
 	    read_or_write,
+	    trap_type,
 	    (intmax_t)frame->badvaddr);
 
 	/* log registers in trap frame */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205291859.q4TIx6DL021590>