Date: Mon, 27 May 2019 12:34:38 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Kubilay Kocak <koobs@freebsd.org>, Rene Ladan <rene@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r502461 - in head/www/chromium: . files Message-ID: <20190527103438.ji35azccjyouu7hu@atuin.in.mat.cc> In-Reply-To: <20190524125813.GA80150@FreeBSD.org> References: <201905241234.x4OCYwWJ055964@repo.freebsd.org> <20190524124243.GA55965@FreeBSD.org> <03e929e1-4f54-3017-1629-3965dd63ee17@FreeBSD.org> <20190524125813.GA80150@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--xpdr4xzjwf5katla Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 24, 2019 at 12:58:13PM +0000, Alexey Dokuchaev wrote: > On Fri, May 24, 2019 at 10:47:36PM +1000, Kubilay Kocak wrote: > > On 24/05/2019 10:42 pm, Alexey Dokuchaev wrote: > > > On Fri, May 24, 2019 at 12:34:58PM +0000, Rene Ladan wrote: > > >> New Revision: 502461 > > >> URL: https://svnweb.freebsd.org/changeset/ports/502461 > > >> > > >> Log: > > >> www/chromium: update to 74.0.3729.157 > > >> =20 > > >> Submitted by: Matthias Wolf via GitHub (#150 #151) > > >> MFH: 2019Q2 > > >=20 > > > Many patches that were modified only changed in metainfo or context > > > (+/- few lines) and thus just cluttered this very noisy commit for > > > no real benefit. > > >=20 > > > Please try to exclude them from the commit batch next time to reduce > > > amount of repochurn. > >=20 > > fwiw, makepatch is now ignoring metadata only changes. Not sure when > > this new feature crept in. >=20 > Technically, line changes are not strictly metadata only changes, and > the old patch might not apply. However, most of the times new address > is within a few lines, and patch(1) can easily find the right context > even when address is off by several hundred lines. >=20 > It might not be very important for small commit batch, but for large > commits, minizing the diff becomes essential since it greatly helps > to understand, rollback, or/and replay changes (especially if there > is some local work in place, e.g. some custom patches). makepatch does not ignore line number changes. When diff generates a patch like this: ---------------------------------------------------------------------- --- perl.c.orig 2019-05-19 06:31:53.000000000 +0000 +++ perl.c 2019-05-20 10:42:27.140534000 +0000 @@ -2009,23 +2009,7 @@ S_Internals_V(pTHX_ CV *cv) PUSHs(Perl_newSVpvn_flags(aTHX_ non_bincompat_options, sizeof(non_bincompat_options) - 1, SVs_TEMP)); -#ifndef PERL_BUILD_DATE -# ifdef __DATE__ ---------------------------------------------------------------------- It will first clean it up, and store this: ---------------------------------------------------------------------- --- perl.c.orig 2019-05-19 06:31:53 UTC +++ perl.c @@ -2009,23 +2009,7 @@ S_Internals_V(pTHX_ CV *cv) PUSHs(Perl_newSVpvn_flags(aTHX_ non_bincompat_options, sizeof(non_bincompat_options) - 1, SVs_TEMP)); -#ifndef PERL_BUILD_DATE -# ifdef __DATE__ ---------------------------------------------------------------------- It will then create a more cleaned up version for comparing, only keeping d= ata and metadata (with both the new and the current patch), which will look like this: ---------------------------------------------------------------------- +++ perl.c @@ -2009,23 +2009,7 @@ PUSHs(Perl_newSVpvn_flags(aTHX_ non_bincompat_options, sizeof(non_bincompat_options) - 1, SVs_TEMP)); -#ifndef PERL_BUILD_DATE -# ifdef __DATE__ ---------------------------------------------------------------------- And if something thanges in this, then the new patch is used. --=20 Mathieu Arnold --xpdr4xzjwf5katla Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlzrvT5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkh8AA//WH/bp2YPDEY7OUaZgrOohb7tnbtQhSwPjeWYmksZT4pb5TLD/oCvKnro RDt5N245AeSF/Damkc8GJ/YrnbPZXsoptJF1woTWY4SFuJUgnVQ6fXeUI/C3B5Ae BsrZZ6bMaxToyev10uXT7Tv6L8ZNNFKiiVipvPLgtOsZ/98U7A025YphWN2QOJjC WDQh3MONuAvQhCa5ZRewH0RNjv4vNTnU/qNGCnrG311UkLKdQw5G0ZWvnp6hElsT OsxF4DkGv3IbhOD0WI0ieTPLByMZNPWd0ekiOLzJgmhtO099HPlxXGdORSGI67Ro b0eLbyGHl3IKGtKPYeURes1qsCtSsWMcV7BU/pxVGrBK14dnSEaHGTAgpGjc3UO/ /PWrX+BzwwujAbx2LcEwgC8ZSuakXvx4Odk0Sj+rDhwlu0k2d44pU45EVRK7+TlI yzhqTDQ/07Pz0pHce1aGUnh4SFkHBLCm1cMZr9PL0IICaI3Y0IwCatrtWw4KGzcW tUG0d741JuKjbxZFcqbTxoj7s3eXdKDegIkUfvRCjzmVO7X6K0tllHHEA7W2MaQw Z5g6XEneRbwyIpDwkW+0oF6pBxPSb3hpaEVW+5KD090T6Lt8DR/JFH3BDOh6Nt+O qqBlnytaTxitSDnSzs+Op6frttGQ2GDWGsPfQOrHcq7agbfq/BY= =NPKc -----END PGP SIGNATURE----- --xpdr4xzjwf5katla--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190527103438.ji35azccjyouu7hu>